Ticket #6619 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] Fix ``inner`` option for integer vectors

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-4.1.1
Component: combinatorics Keywords: inner, integer vectors
Cc: sage-combinat, burcin Work issues:
Report Upstream: Reviewers: Dan Drake
Authors: Nicolas M. Thiéry Merged in: Sage 4.1.1.alpha1
Dependencies: Stopgaps:

Description (last modified by nthiery) (diff)

Those examples did not pass due to a typo in the code. 

            sage: IV = IntegerVectors(3,10,inner=[4,1,3], min_part = 2)
            sage: min_length, max_length, floor, ceiling, min_slope, max_slope = IV._parameters()
            sage: floor(1), floor(2), floor(3)
            (4, 2, 3)

            sage: IV = IntegerVectors(3, 10, outer=[4,1,3], max_part = 3)
            sage: min_length, max_length, floor, ceiling, min_slope, max_slope = IV._parameters()
            sage: ceiling(1), ceiling(2), ceiling(3)
            (3, 1, 3)

Attachments

trac_6619_integer_vector_inner-fix-nt.patch Download (1.6 KB) - added by nthiery 4 years ago.

Change History

Changed 4 years ago by nthiery

comment:1 Changed 4 years ago by nthiery

  • Cc burcin added
  • Description modified (diff)

comment:2 Changed 4 years ago by nthiery

  • Owner changed from tbd to nthiery
  • Status changed from new to assigned

comment:3 Changed 4 years ago by ddrake

  • Reviewers changed from Burcin Erocal to Dan Drake
  • Component changed from algebra to combinatorics
  • Summary changed from [with patch, needs review] Fix ``inner`` option for integer vectors to [with patch, positive review] Fix ``inner`` option for integer vectors

Positive review.

comment:4 Changed 4 years ago by mvngu

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Merged in set to Sage 4.1.1.alpha1
Note: See TracTickets for help on using tickets.