Ticket #6597 (closed enhancement: fixed)
[with patch, positive review] SetMorphism: 100% doctest + equality + pickling; depends on #6343
| Reported by: | nthiery | Owned by: | nthiery |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.1.2 |
| Component: | coercion | Keywords: | doctest, SetMorphism, pickling |
| Cc: | sage-combinat, cwitty, saliola | Work issues: | |
| Report Upstream: | Reviewers: | Mike Hansen | |
| Authors: | Nicolas M. Thiéry | Merged in: | Sage 4.1.2.alpha2 |
| Dependencies: | Stopgaps: |
Description (last modified by nthiery) (diff)
This patch raises SetMorphism? to 100% doctest, and implements equality and pickling.
It also renames and doctests the following methods in Map, which were unused and not doctested:
- test_extra_slots -> _extra_slots_test
- update_slots_test -> _update_slots_test
It depends on #6343 (TestSuite?)
The category patches #5891
Attachments
-
trac_6597_set_morphism_doc_pickling.patch
(8.1 KB) -
added by nthiery 4 years ago.
Change History
comment:1 Changed 4 years ago by nthiery
- Owner changed from robertwb to nthiery
- Status changed from new to assigned
- Description modified (diff)
- Summary changed from [with patch, needs review] SetMorphism: 100% doctest + equality + pickling to [with patch, needs review] SetMorphism: 100% doctest + equality + pickling; depends on #6343
comment:3 follow-up: ↓ 4 Changed 4 years ago by mhansen
- Reviewers set to Mike Hansen
- Summary changed from [with patch, needs review] SetMorphism: 100% doctest + equality + pickling; depends on #6343 to [with patch, positive review] SetMorphism: 100% doctest + equality + pickling; depends on #6343
Looks good to me. All tests pass with it once #6343 is applied to Sage 4.1.1.
Note it takes awhile to build everything.
comment:4 in reply to: ↑ 3 Changed 4 years ago by nthiery
Replying to mhansen:
Looks good to me. All tests pass with it once #6343 is applied to Sage 4.1.1.
Thanks Mike for the review!
Note it takes awhile to build everything.
Yeah, I had to modify the .pxd of Map (or Morphism) to get pickling to work.
I am glad this will be soon in so that we don't have this patch anymore in Sage-Combinat.
Note: See
TracTickets for help on using
tickets.
