Ticket #6526 (closed defect: fixed)

Opened 14 months ago

Last modified 14 months ago

[with patch, positive review] remove naive suffix trees

Reported by: rlm Owned by: mhansen
Priority: major Milestone: sage-4.1.1
Component: combinatorics Keywords:
Cc: saliola Author(s): Robert Miller
Report Upstream: Reviewer(s): Franco Saliola
Merged in: sage-4.1.1.alpha0 Work issues:

Description

This is one of the obstructions to switching the graph backends over to Cython by default.

To quote Franco:

But all the doctest failures occur in the NaiveSuffixTreeClass, which
is a naive implementation. This code was only intended for testing
purposes, so I think it is fine to delete it (delete both
NaiveSuffixTree and NaiveSuffixTreeClass). I am pretty certain it is
not used anywhere else (it should not be, if it is), because it is a
very slow implementation (hence, the name naive).

Attachments

trac_6526-remove-naive-suffix-tree.patch Download (10.0 KB) - added by rlm 14 months ago.
based on #6519

Change History

Changed 14 months ago by rlm

This will be based on #6519.

Changed 14 months ago by rlm

based on #6519

Changed 14 months ago by rlm

  • cc saliola added
  • summary changed from remove naive suffix trees to [with patch, needs review] remove naive suffix trees
  • author set to Robert Miller

Changed 14 months ago by saliola

  • summary changed from [with patch, needs review] remove naive suffix trees to [with patch, positive review] remove naive suffix trees

Positive review.

Changed 14 months ago by mvngu

  • status changed from new to closed
  • reviewer set to Franco Saliola
  • resolution set to fixed
  • merged set to sage-4.1.1.alpha0
Note: See TracTickets for help on using tickets.