Ticket #6507 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] doc sidebar toggle

Reported by: mpatel Owned by: tba
Priority: minor Milestone: sage-4.1.2
Component: documentation Keywords:
Cc: Work issues:
Report Upstream: Reviewers: Tim Dumol
Authors: Mitesh Patel Merged in: Sage 4.1.2.alpha4
Dependencies: Stopgaps:

Description

See  sage-devel for an early version.

Attachments

trac_6507_sidebar_toggle.patch Download (3.2 KB) - added by mpatel 4 years ago.

Change History

Changed 4 years ago by mpatel

comment:1 Changed 4 years ago by mpatel

The new toggle highlights itself on mouse-over, runs the length of the content, auto-resizes itself, uses cookies, and should work in the live, static, and offline documentation in most browsers. This includes Firefox, Opera, and the Qt WebKit demo browser on Linux. Chromium, it seems, does not yet let offline pages set cookies, but more polish is on order.

comment:2 Changed 4 years ago by timdumol

  • Summary changed from [with patch, needs review] doc sidebar toggle to [with patch, needs work] doc sidebar toggle

I applied the patch on r12658 (Sage 4.1). There do not appear to be any differences in the UI.

comment:3 Changed 4 years ago by mpatel

Can you be more specific, e.g., about the browser and OS? Did you rebuild the HTML documentation?

I should add that I don't have access to a machine running Mac OS. It would be useful to know how it fares in multiple Mac OS browsers in all three scenarios (live, fast static, offline).

But first, we should try to get it working on some machine other than mine.

(In applying the patch, I got this warning: 

Hunk #1 succeeded at 9 with fuzz 1 (offset -1 lines).

This is just a consequence of #6512.)

comment:4 Changed 4 years ago by mpatel

  • Summary changed from [with patch, needs work] doc sidebar toggle to [with patch, needs review] doc sidebar toggle

Apart from the "fuzz" mentioned above, the patch still appears to work for me. I'm changing the summary to WPNR, but please let me know...

comment:5 Changed 4 years ago by timdumol

  • Reviewers set to Tim Dumol
  • Summary changed from [with patch, needs review] doc sidebar toggle to [with patch, positive review] doc sidebar toggle

Works as advertised after a doc rebuild. Positive review.

comment:6 Changed 4 years ago by mvngu

  • Status changed from new to closed
  • Resolution set to fixed
  • Merged in set to Sage 4.1.2.alpha3
  • Milestone set to sage-4.1.2

comment:7 Changed 4 years ago by mvngu

  • Merged in changed from Sage 4.1.2.alpha3 to Sage 4.1.2.alpha4

There is no 4.1.2.alpha3. Sage 4.1.2.alpha3 was William Stein's release for working on making the notebook a standalone package.

Note: See TracTickets for help on using tickets.