Ticket #647 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

[with patch] create a quaternion algebra element class

Reported by: was Owned by: somebody
Priority: major Milestone: sage-2.8.5
Component: basic arithmetic Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

From Alex Ghitza: 

I fiddled a bit more with the quaternion algebras, this time with
elements.  This is still warm-up for doing something more serious with
orders and ideals, starting with implementing the code by
Rodriguez-Villegas et al.

See attached patch.

Attachments

quatalgelm.hg Download (3.0 KB) - added by was 3 years ago.
newquatalgelm.hg Download (2.0 KB) - added by AlexGhitza 3 years ago.

Change History

Changed 3 years ago by was

Changed 3 years ago by was

The main thing that needs to happen to close this ticket is that 1-2 people need to look at this patch and say "yep, looks good".

Changed 3 years ago by was

OK, I just looked at it, and it *has* no doctests at all for the new functions it introduces. Please add these.

Changed 3 years ago by AlexGhitza

Changed 3 years ago by AlexGhitza

  • milestone changed from sage-2.9.1 to sage-2.8.4.3

I inserted doctests and attached the new version newquatalgelm.hg.

Changed 3 years ago by mhansen

  • summary changed from create a quaternion algebra element class to [with patch] create a quaternion algebra element class

Changed 3 years ago by was

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.