Ticket #6457 (closed defect: fixed)

Opened 14 months ago

Last modified 14 months ago

[with patch, positive review] Intersection of ideals in a number field

Reported by: davidloeffler Owned by: was
Priority: minor Milestone: sage-4.1.1
Component: number theory Keywords: ideals
Cc: Author(s): David Loeffler
Report Upstream: Reviewer(s): Nick Alexander
Merged in: sage-4.1.1.alpha0 Work issues:

Description

This is not difficult but for some reason it wasn't implemented before. Here it is.

Attachments

trac_6457-ideal_intersection.patch Download (1.8 KB) - added by davidloeffler 14 months ago.
patch against 4.1.alpha2

Change History

Changed 14 months ago by davidloeffler

patch against 4.1.alpha2

Changed 14 months ago by davidloeffler

  • keywords ideals added; ideal removed
  • summary changed from Intersection of ideals in a number field to [with patch, needs review] Intersection of ideals in a number field

Changed 14 months ago by ncalexan

  • reviewer set to David Loeffler
  • summary changed from [with patch, needs review] Intersection of ideals in a number field to [with patch, positive review] Intersection of ideals in a number field
  • author set to Nick Alexander

These doctests don't convince me that the the results are correct, but I don't see a one line way to assert that, so: positive review!

Changed 14 months ago by mvngu

  • status changed from new to closed
  • reviewer changed from David Loeffler to Nick Alexander
  • resolution set to fixed
  • merged set to sage-4.1.1.alpha0
  • author changed from Nick Alexander to David Loeffler

I assume David is the author of trac_6457-ideal_intersection.patch, since Nick reviewed this ticket. David, the patch trac_6457-ideal_intersection.patch doesn't contain your username. So I'm committing it in your name.

Note: See TracTickets for help on using tickets.