Ticket #6450 (closed enhancement: fixed)

Opened 8 months ago

Last modified 8 months ago

[with patch, positive review] add generic group functions to the documentation

Reported by: ylchapuy Owned by: tba
Priority: minor Milestone: sage-4.1.1
Component: documentation Keywords: generic group documentation
Cc: Author(s): Yann Laigle-Chapuy
Report Upstream: Reviewer(s): John Cremona
Merged in: sage-4.1.1.alpha0 Work issues:

Description

Those are the functions in sage/groups/generic.py

Attachments

trac_6450_generic_group_doc.patch Download (31.1 KB) - added by ylchapuy 8 months ago.
trac_6450_review.patch Download (17.0 KB) - added by cremona 8 months ago.
Apply after previous

Change History

Changed 8 months ago by ylchapuy

Changed 8 months ago by cremona

Apply after previous

Changed 8 months ago by cremona

  • keywords generic group documentation added
  • reviewer set to John Cremona
  • summary changed from add generic group functions to the documentation to [with new patch, needs review] add generic group functions to the documentation

Thanks for working on this! It's a great thing to have this file appearing in the reference manual.

I checked that the docs built ok after the patch (which applied fine to 4.1.alpha2), then added a second patch which tidies up the documentation a bit -- since I wrote most of it, I thought that was my duty.

ylchapuy, if you approve of my additional patch then you can give this a postive review.

Changed 8 months ago by ylchapuy

  • summary changed from [with new patch, needs review] add generic group functions to the documentation to [with patch, positive review] add generic group functions to the documentation

Nice job. It looks fine to me.

Changed 8 months ago by mvngu

  • status changed from new to closed
  • resolution set to fixed
  • merged set to sage-4.1.1.alpha0

Merged both patches.

Note: See TracTickets for help on using tickets.