Ticket #6438 (closed enhancement: fixed)

Opened 14 months ago

Last modified 14 months ago

[with spkg, positive review] Upgrade to Cython 0.11.2

Reported by: robertwb Owned by: mabshoff
Priority: major Milestone: sage-4.1.1
Component: packages Keywords:
Cc: Author(s): Robert Bradshaw
Report Upstream: Reviewer(s): Minh Van Nguyen
Merged in: Sage 4.1.1.alpha1 Work issues:

Description

At the very least, native complex support will be valuable.

The spkg at  http://sage.math.washington.edu/home/robertwb/cython/ built and passed all doctests a couple of versions back.

Attachments

6438-cython.patch Download (0.8 KB) - added by robertwb 14 months ago.

Change History

Changed 14 months ago by mhansen

  • summary changed from Upgrade to Cython 0.11.2 to [with spkg, needs review] Upgrade to Cython 0.11.2

Changed 14 months ago by robertwb

We should update to the latest tip to fix the numpy issue.

Changed 14 months ago by jason

Does your comment mean that we need a new spkg? Is this a "needs work" ticket now?

Changed 14 months ago by jason

  • summary changed from [with spkg, needs review] Upgrade to Cython 0.11.2 to [with spkg, needs work] Upgrade to Cython 0.11.2

Changed 14 months ago by jason

On the other hand, the spkg seems fine, except that the SPKG.txt file does not include a changelog of any sort. Shouldn't this be added?

Changed 14 months ago by robertwb

  • summary changed from [with spkg, needs work] Upgrade to Cython 0.11.2 to [with spkg, needs review] Upgrade to Cython 0.11.2

 http://sage.math.washington.edu/home/robertwb/cython/cython-0.11.2.1.spkg

I don't see anything in SPKG.txt that needs changing--the changelog would be pretty boring if it was there ("Upgraded to version x.y.z" * 100).

Changed 14 months ago by robertwb

Changed 14 months ago by robertwb

All tests pass with the above spkg and patch.

Changed 14 months ago by mvngu

The SPKG at

 http://sage.math.washington.edu/home/robertwb/cython/cython-0.11.2.1.spkg

doesn't contain a file called .hgignore like the current version in Sage 4.1. So when one executes the command

hg status

one sees a lot of source files. I've added a .hgignore file to the repository of that SPKG. The updated SPKG is up at

 http://sage.math.washington.edu/home/mvngu/patch/cython-0.11.2.1.spkg

All doctests passed with the latter SPKG and 6438-cython.patch.

Changed 14 months ago by mvngu

  • status changed from new to closed
  • author set to Robert Bradshaw
  • summary changed from [with spkg, needs review] Upgrade to Cython 0.11.2 to [with spkg, positive review] Upgrade to Cython 0.11.2
  • reviewer set to Minh Van Nguyen
  • resolution set to fixed
  • merged set to Sage 4.1.1.alpha1
Note: See TracTickets for help on using tickets.