Ticket #643 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[with patch] notebook -- fix space issues with the top bar.

Reported by: was Owned by: was
Priority: major Milestone: sage-2.8.7
Component: notebook Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

On 9/12/07, Marshall Hampton <hamptonio@gmail.com> wrote:
>
> I am very happy that the new notebook is more secure, and so I first
> want to thank everyone who worked on it.
>
> There is one thing that bothers me a lot: I treasure my screen real
> estate, and there is a large (about 1") gap between the useful stuff
> in the outer frame (the file menu, use/edit/text/etc) and the frame
> with the cells.  Is there a way to shrink that?
>

Yes, by appropriately rewriting some of the css that defines the page
in sage/notebook/server/css.py.
I wish somebody would do that and send me a patch.

Note that if you just shrink the space on your machine, it will actually
completely cover up all the controls on the top on many other machines.
It's very very system dependent.  Having extra space is the only reasonable
solution until somebody sits down and does this right.

Attachments

example.html Download (23.1 KB) - added by was 3 years ago.
timothy clemans wrote this example, which seems to be a good idea -- it uses javascript
643.patch Download (2.2 KB) - added by mhansen 3 years ago.
643.2.patch Download (1.2 KB) - added by TimothyClemans 3 years ago.
added resize fix
643.3.patch Download (1.2 KB) - added by TimothyClemans 3 years ago.
css.patch Download (6.5 KB) - added by mhansen 3 years ago.
toggle.2.patch Download (1 bytes) - added by mhansen 3 years ago.
Accidental upload
toggle.patch Download (2.7 KB) - added by mhansen 3 years ago.

Change History

Changed 3 years ago by was

timothy clemans wrote this example, which seems to be a good idea -- it uses javascript

Changed 3 years ago by mhansen

  Changed 3 years ago by mhansen

  • summary changed from notebook -- fix space issues with the top bar. to [with patch] notebook -- fix space issues with the top bar.

  Changed 3 years ago by TimothyClemans

  • status changed from new to closed
  • resolution set to fixed

  Changed 3 years ago by TimothyClemans

  • status changed from closed to reopened
  • resolution fixed deleted

  Changed 3 years ago by was

This doesn't work for me at all.

see attached screenshot in ubuntu 7.04 linux.

Changed 3 years ago by TimothyClemans

added resize fix

in reply to: ↑ 5   Changed 3 years ago by TimothyClemans

Replying to was:

 http://sage.math.washington.edu/tmp/snapshot1.png

Ok I think I found what happened. I added the div before the last table in the top bar. It is kind of confusing since it is in _html_body instead of html_worksheet_topbar. I'll fix that and upload patch 3.

Changed 3 years ago by TimothyClemans

  Changed 3 years ago by was

  • owner changed from boothby to was
  • status changed from reopened to new
  • milestone changed from sage-2.9 to sage-2.8.6

  Changed 3 years ago by mhansen

I made some changes to improve the notebook. Could people try out my patch and see if it breaks / does anything stupid on other browsers?

It looks like there is a fair amount of cleaning up to do.

Changed 3 years ago by mhansen

Changed 3 years ago by mhansen

Accidental upload

Changed 3 years ago by mhansen

  Changed 3 years ago by was

  • milestone changed from sage-2.8.6 to sage-2.8.7

  Changed 3 years ago by was

Please post one patch bundle, so I know what to actually apply.

  Changed 3 years ago by was

  • status changed from new to closed
  • resolution set to fixed

Very nice!

Note: See TracTickets for help on using tickets.