Ticket #6417 (closed enhancement: fixed)

Opened 14 months ago

Last modified 14 months ago

[with patch, positive review] Unicode in LaTeX

Reported by: mora Owned by: cwitty
Priority: major Milestone: sage-4.1
Component: misc Keywords: unicode LaTeX
Cc: Author(s): Peter Mora
Report Upstream: Reviewer(s): John Palmieri
Merged in: sage-4.1.rc0 Work issues:

Description

In a %latex cell I couldn't use any accentuated letter. I had to write \"o to get ö.

Using this patch I can write unicode characters directly. For example Hungarian chars:

 http://www.math.bme.hu/~morap/sage_unicode_latex.png

This feature is important because most of the world uses more than the first 128 characters of ANSII.

Attachments

12538.patch Download (1.2 KB) - added by mora 14 months ago.

Change History

Changed 14 months ago by mora

  Changed 14 months ago by mora

  • summary changed from Unicode in LaTeX to [with patch, needs review] Unicode in LaTeX

  Changed 14 months ago by jhpalmieri

  • summary changed from [with patch, needs review] Unicode in LaTeX to [with patch, positive review] Unicode in LaTeX

Looks good to me except that it doesn't pass doctests. Apply the patch at #6434 and you're good to go.

So this patch depends on #6434; modulo that, positive review.

  Changed 14 months ago by rlm

  • summary changed from [with patch, positive review] Unicode in LaTeX to [with patch, needs work] Unicode in LaTeX

sage -t "devel/sage-main/sage/misc/latex.py" fails after applying this patch.

follow-up: ↓ 5   Changed 14 months ago by jhpalmieri

  • summary changed from [with patch, needs work] Unicode in LaTeX to [with patch, positive review] Unicode in LaTeX

sage -t "devel/sage-main/sage/misc/latex.py" fails after applying this patch.

As my comment says, doctests don't pass until you apply the patch at #6434. Once #6434 gets in, this one is ready to go. Is there some way to label this besides "positive review" to indicate this?

in reply to: ↑ 4   Changed 14 months ago by rlm

Replying to jhpalmieri:

sage -t "devel/sage-main/sage/misc/latex.py" fails after applying this patch.

As my comment says, doctests don't pass until you apply the patch at #6434.

My bad, wasn't paying enough attention.

  Changed 14 months ago by rlm

  • status changed from new to closed
  • reviewer set to John Palmieri
  • resolution set to fixed
  • merged set to sage-4.1.rc0
  • author set to Peter Mora

  Changed 14 months ago by mvngu

See #6464 for a related issue. It concerns Unicode in Notebook worksheets.

Note: See TracTickets for help on using tickets.