Ticket #6407 (closed enhancement: fixed)

Opened 8 months ago

Last modified 7 months ago

[with patch, positive review] Multiplication-by-n method on elliptic curve formal groups should use the double-and-add algorithm

Reported by: hlaw Owned by: hlaw
Priority: minor Milestone: sage-4.1.1
Component: performance Keywords: formal group elliptic curve
Cc: Author(s): Hamish Ivey-Law, Tom Boothby
Report Upstream: Reviewer(s): Robert Miller
Merged in: Sage 4.1.1.alpha1 Work issues:

Description

Currently EllipticCurveFormalGroup.mult_by_n() is implemented simply by applying the group law to itself n times (except when working over a field of characteristic zero, in which case a fast algorithm is used). This linear algorithm should be replaced with the logarithmic double-and-add algorithm (i.e. the additive version of the standard square-and-multiply algorithm).

Attachments

trac_6407_added_double-and-add_algo_to_EllipticCurveFormalGroup.patch Download (2.8 KB) - added by hlaw 7 months ago.
6407_part2.patch Download (1.1 KB) - added by boothby 7 months ago.

Change History

Changed 8 months ago by hlaw

  • status changed from new to assigned

Changed 7 months ago by hlaw

  • summary changed from Multiplication-by-n method on elliptic curve formal groups should use the double-and-add algorithm to [with patch, needs review] Multiplication-by-n method on elliptic curve formal groups should use the double-and-add algorithm

Changed 7 months ago by boothby

Changed 7 months ago by boothby

hlaw's implementation of the double-and-add algorithm resulted in a wasted doubling at the end -- potentially expensive. My part2 patch is a slight improvement.

Changed 7 months ago by rlm

  • summary changed from [with patch, needs review] Multiplication-by-n method on elliptic curve formal groups should use the double-and-add algorithm to [with patch, positive review] Multiplication-by-n method on elliptic curve formal groups should use the double-and-add algorithm

Looks good to me.

Changed 7 months ago by mvngu

  • reviewer set to Robert Miller
  • author set to Hamish Ivey-Law, Tom Boothby

Changed 7 months ago by mvngu

  • status changed from assigned to closed
  • resolution set to fixed
  • merged set to Sage 4.1.1.alpha1
Note: See TracTickets for help on using tickets.