Ticket #6244 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] conjugate() in sage-4.0 is broken

Reported by: gmhossain Owned by: burcin
Priority: major Milestone: sage-4.0.2
Component: symbolics Keywords: conjugate, pynac
Cc: ncalexan Work issues:
Report Upstream: Reviewers: Nick Alexander
Authors: Burcin Erocal Merged in: 4.0.2.alpha0
Dependencies: Stopgaps:

Description

1) pynac .conjugate() method returns wrong answer:

f(x) = function('f',x)
f(x).conjugate()

f(conjugate(x))

Above is certainly not true. For example: f(x) = I + x implies f(x).conjugate() = -I + conjugate(x) which is not equal to f(conjugate(x))

2) view() causes SIGSEGV crash

f(x) = function('f',x)
g(x) = f(x).conjugate()
view( g(x) )
boom!!

Attachments

trac_6244-conjugate.patch Download (12.4 KB) - added by burcin 4 years ago.

Change History

comment:1 Changed 4 years ago by burcin

  • Owner set to burcin
  • Status changed from new to assigned
  • Milestone set to sage-4.0.2

I have a fix for (1) above, don't know about (2) yet. Same issue effects .real_part(), .imag_part(), etc. functions.

Changed 4 years ago by burcin

comment:2 Changed 4 years ago by burcin

  • Cc ncalexan added
  • Summary changed from conjugate() in sage-4.0 is broken to [with patch, needs review] conjugate() in sage-4.0 is broken

This is fixed in the new pynac package here:

 http://sage.math.washington.edu/home/burcin/pynac/pynac-0.1.8.p0.spkg

Since the package also contains fixes for #6256 and #6211, the doctests should be run with those patches applied.

Besides adding doctests for the fix, the patch cleans up symbolic functions and adds correct conversions for asin, asinh, acos, acosh, and atan.

Nick, can you review this?

comment:3 Changed 4 years ago by ncalexan

  • Status changed from assigned to closed
  • Authors set to Burcin Erocal
  • Summary changed from [with patch, needs review] conjugate() in sage-4.0 is broken to [with patch, positive review] conjugate() in sage-4.0 is broken
  • Reviewers set to Nick Alexander
  • Resolution set to fixed
  • Merged in set to 4.0.2.alpha0

Fine by me.

Note: See TracTickets for help on using tickets.