Ticket #6209 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with spkg, with positive review] fix flint

Reported by: was Owned by: mhansen
Priority: blocker Milestone: sage-4.0.1
Component: build Keywords:
Cc: Work issues:
Report Upstream: Reviewers: Bill Hart
Authors: Mike Hansen Merged in: 4.0.1.rc1
Dependencies: Stopgaps:

Description 

in fmpz.c change

#include "zn_poly/zn_poly.h"

to

#include "zn_poly/src/zn_poly.h"

Also, in the FLINT makefile

-DNEBUG -> -DNDEBUG

in a couple of places. David Harvey found these.

These will fix the issues you note. The next version of FLINT due at
the end of June will have these fixes.

 -- Bill Hart

Change History

comment:1 Changed 4 years ago by mhansen

  • Owner changed from tbd to mhansen
  • Status changed from new to assigned
  • Summary changed from fix flint to [with spkg, needs review] fix flint

I've made these changes and put them in  http://sage.math.washington.edu/home/mhansen/flint-1.2.5.p0.spkg

comment:2 Changed 4 years ago by wbhart

  • Summary changed from [with spkg, needs review] fix flint to [with spkg, needs work] fix flint

The fmpz.c file still has #include "zn_poly/zn_poly.h"

comment:3 Changed 4 years ago by mhansen

Did you look in the fmpz.c file in the patches/directory? That overwrites the one in the the src/ before the build.

comment:4 Changed 4 years ago by wbhart

  • Summary changed from [with spkg, needs work] fix flint to [with spkg, with positive review] fix flint

Sorry, my mistake. It's fixed in patches not src indeed!!

comment:5 Changed 4 years ago by mhansen

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in 4.0.1.rc1.

comment:6 Changed 4 years ago by mhansen

  • Reviewers set to Bill Hart
  • Merged in set to 4.0.1.rc1
  • Authors set to Mike Hansen
Note: See TracTickets for help on using tickets.