Ticket #6192 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch; positive review] numerical noise on x86 fedora core 8 (cicero on skynet)

Reported by: was Owned by: tbd
Priority: blocker Milestone: sage-4.0.1
Component: algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers: Mike Hansen
Authors: William Stein Merged in: 4.0.1.rc0
Dependencies: Stopgaps:

Description 

sage -t  "devel/sage/sage/calculus/calculus.py"
**********************************************************************
File "/home/wstein/build-4.4.0/cicero/sage-4.0.1.alpha0/devel/sage/sage/calculus/calculus.py", line 700:
    sage: numerical_integral(f, 0, 1)
Expected:
    (0.52848223225314706, 6.8392846084921134e-07)
Got:
    (0.52848223225314706, 6.8392846078917534e-07)
**********************************************************************
1 items had failures:
   1 of  16 in __main__.example_2

Noise or a bug? 

sage -t  "devel/sage/sage/rings/number_field/number_field_element.pyx"
**********************************************************************
File "/home/wstein/build-4.4.0/cicero/sage-4.0.1.alpha0/devel/sage/sage/rings/number_field/number_field_element.pyx", line 
766:
    sage: CDF(a)
Expected:
    1.0*I
Got:
    -2.88668828424e-18 - 1.0*I
**********************************************************************
1 items had failures:
   1 of   4 in __main__.example_21
***Test Failed*** 1 failures.

Attachments

trac_6192.patch Download (1.2 KB) - added by was 4 years ago.

Change History

comment:1 Changed 4 years ago by was

The second issue is because the roots of x2+1 are "sorted" as complex numbers, and because of numerical noise, the roots are swapped.

Changed 4 years ago by was

comment:2 Changed 4 years ago by was

  • Summary changed from numerical noise on x86 fedora core 8 (cicero on skynet) to [with patch; needs review] numerical noise on x86 fedora core 8 (cicero on skynet)

comment:3 Changed 4 years ago by mhansen

  • Status changed from new to closed
  • Resolution set to fixed
  • Summary changed from [with patch; needs review] numerical noise on x86 fedora core 8 (cicero on skynet) to [with patch; positive review] numerical noise on x86 fedora core 8 (cicero on skynet)

Looks good to me.

Merged in 4.0.1.rc0.

comment:4 Changed 4 years ago by mhansen

  • Reviewers set to Mike Hansen
  • Merged in set to 4.0.1.rc0
  • Authors set to William Stein
Note: See TracTickets for help on using tickets.