Ticket #6138 (closed enhancement: fixed)

Opened 10 months ago

Last modified 4 months ago

SymmetricGroupAlgebra: updates w.r.t. categories and free modules

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-4.3
Component: combinatorics Keywords: symmetric group, free module
Cc: sage-combinat Author(s): Nicolas M. Thiéry
Report Upstream: Reviewer(s): Florent Hivert
Merged in: sage-4.3.alpha0 Work issues:

Description (last modified by hivert) (diff)

The goal of the patch is to adapt SymmetricGroupAlgebra? to categories and to add some improvements. The patch improve SymmetricGroupAlgebra? in two ways:

  • When creating SGA(n) a coercion from SGA(n-1) is declared.

I'm submitting the patch on behalf on Nicolas after reviewing it.

Depends on the categories framework #5891, #6136.

Cheers,

Florent

Attachments

categories-symmetric_group_algebra-6138-nt.patch Download (10.7 KB) - added by hivert 5 months ago.
trac_6138-categories-symmetric_group_algebra-6138-nt.patch Download (12.0 KB) - added by nthiery 4 months ago.
Updated patch fixes two missing doctests (apply only this one)

Change History

Changed 5 months ago by hivert

  Changed 5 months ago by hivert

  • status changed from new to needs_review
  • reviewer set to Florent Hivert
  • description modified (diff)
  • author set to Nicolas M. Thiéry

  Changed 5 months ago by hivert

  • status changed from needs_review to positive_review

follow-up: ↓ 4   Changed 5 months ago by mhansen

For this, isn't it possible to lazily add the coercion using coerce_map_from?

in reply to: ↑ 3   Changed 5 months ago by nthiery

Replying to mhansen:

For this, isn't it possible to lazily add the coercion using coerce_map_from?

Probably so. It would be best handled by some "templated coercion declarations", as I had started to implement in MuPAD. Let's just leave it as is for the moment, until we have enough use cases to come up with the right design.

Changed 4 months ago by nthiery

Updated patch fixes two missing doctests (apply only this one)

  Changed 4 months ago by mhansen

  • status changed from positive_review to closed
  • resolution set to fixed
  • merged set to sage-4.3.alpha0
Note: See TracTickets for help on using tickets.