Ticket #6136 (closed enhancement: fixed)

Opened 15 months ago

Last modified 10 months ago

(Combinatorial) Free modules: cleanup, abstraction into categories, and functorial constructions

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-4.3
Component: algebra Keywords: free modules, categories, tensor, direct sum
Cc: sage-combinat Author(s): Nicolas M. Thiéry
Report Upstream: Reviewer(s): Florent Hivert
Merged in: sage-4.3.alpha0 Work issues:

Description (last modified by nthiery) (diff)

  • Deprecates CombinatorialAlgebra?
  • Abstracts some of the generic code into ModulesWithBasis?, Algebras, ...
  • Implements the functorial constructions: tensor and cartesian product
  • Stronger type checking, use UniqueRepresentation?
  • Disabled dangerous conversions (see doc of _element_constructor), strict contains
  • Naming cleanup: _term -> term, repr -> _repr_, _element_class -> element_class _combinatorial_class -> _basis_keys
  • New methods: monomial, sum_of_terms, sum_of_monomials, term_or_zero_if_none, from_vector, _repr_term, _repr_option_bracket
  • More interesting an_element, using heuristics
  • Handle non sortable objects in repr
  • Implements sage.categories.poor_man_map.PoorManMap? for maps between sets which are not modelled by parents.
  • This is used to make term and sum_of_monomial into maps, with codomain and composition.

Depends on the category patches. See  http://sagetrac.org/sage_trac/wiki/CategoriesRoadMap.

Attachments

categories-freemodule-6136-nt.patch Download (88.0 KB) - added by nthiery 10 months ago.
trac_6136-categories-freemodule-nt.patch Download (91.0 KB) - added by nthiery 10 months ago.
Adds TestSuite?.run call, and implements equality for PoorManMap?'s. Apply only this one.
trac_6136-categories-freemodule-nt.2.patch Download (92.5 KB) - added by hivert 10 months ago.
Last version of the file from combinat patch server.
trac_6136-categories-freemodule-nt.3.patch Download (92.5 KB) - added by hivert 10 months ago.
Correct version

Change History

Changed 15 months ago by nthiery

  • description modified (diff)

Changed 10 months ago by nthiery

Changed 10 months ago by nthiery

  • status changed from new to needs_review
  • reviewer set to Florent Hivert
  • description modified (diff)
  • author set to Nicolas M. Thiéry

Changed 10 months ago by nthiery

Adds TestSuite?.run call, and implements equality for PoorManMap?'s. Apply only this one.

Changed 10 months ago by hivert

Last version of the file from combinat patch server.

Changed 10 months ago by hivert

  • status changed from needs_review to positive_review

Changed 10 months ago by hivert

Apply only the last patch trac_6136-categories-freemodule-nt.2.patch

Note: it breaks some doctests which are corrected in #6137 (See  http://sagetrac.org/sage_trac/wiki/CategoriesRoadMap)

Ready to go.

Cheers,

Florent

Changed 10 months ago by hivert

Correct version

Changed 10 months ago by mhansen

  • status changed from positive_review to closed
  • resolution set to fixed
  • merged set to sage-4.3.alpha0
Note: See TracTickets for help on using tickets.