Ticket #6098 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] 3d bezier path plotting

Reported by: ekirkman Owned by: ekirkman
Priority: major Milestone: sage-4.1.1
Component: graphics Keywords:
Cc: rlm, mhansen Work issues:
Report Upstream: Reviewers: Robert Miller
Authors: Emily Kirkman Merged in: sage-4.1.1.alpha0
Dependencies: Stopgaps:

Description


Attachments

curve.jpg Download (23.1 KB) - added by ekirkman 4 years ago.
This picture was created with input sage: bezier3d((0,0,0),(1,0,0),(0,1,0),(0,1,1)?)
trac6098_bezier3d.patch Download (9.7 KB) - added by rlm 4 years ago.
Referee edit
trac_6098-rebased.patch Download (9.1 KB) - added by rlm 4 years ago.
Apply only this patch

Change History

comment:1 Changed 4 years ago by ekirkman

  • Summary changed from 3d bezier path plotting to [with patch, needs review] 3d bezier path plotting

Changed 4 years ago by ekirkman

This picture was created with input sage: bezier3d((0,0,0),(1,0,0),(0,1,0),(0,1,1)?)

Changed 4 years ago by rlm

Referee edit

comment:2 Changed 4 years ago by rlm

  • Summary changed from [with patch, needs review] 3d bezier path plotting to [with patch, positive review] 3d bezier path plotting

comment:3 Changed 4 years ago by ncalexan

  • Reviewers set to Robert Miller
  • Summary changed from [with patch, positive review] 3d bezier path plotting to [with patch, needs work] 3d bezier path plotting
  • Authors set to Emily Kirkman

Unfortunately, against 4.0.2.alpha0: 

----------------------------------------------------------------------

The following tests failed:

        sage -t -long devel/sage/sage/plot/plot3d/shapes2.py # 4 doctests failed
        sage -t -long devel/sage/sage/plot/plot3d/shapes2.py # 4 doctests failed
        sage -t -long devel/sage/sage/plot/bezier_path.py # 2 doctests failed
----------------------------------------------------------------------

Changed 4 years ago by rlm

Apply only this patch

comment:4 Changed 4 years ago by rlm

  • Summary changed from [with patch, needs work] 3d bezier path plotting to [with patch, positive review] 3d bezier path plotting

It was completely trivial to get this patch working again. I did the work while Emily watched over my shoulder. If one positive review isn't enough, then you have two! :)

comment:5 Changed 4 years ago by mvngu

Oops... ignore the patch trac_6098-reviewer.patch. Just to let people know, only the patch trac_6098-rebased.patch has been merged in sage-4.1.1-alpha0. I can't close this ticket because I don't have the privilege to do so. Sorry, folks :-(

comment:6 Changed 4 years ago by mvngu

  • Status changed from new to closed
  • Resolution set to fixed
  • Merged in set to sage-4.1.1.alpha0
Note: See TracTickets for help on using tickets.