Ticket #6078 (closed defect: invalid)

Opened 4 years ago

Last modified 4 years ago

Add compatibility functions with deprecation warnings for QF code after doctest patch

Reported by: tornaria Owned by: justin
Priority: blocker Milestone: sage-4.0.2
Component: quadratic forms Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description (last modified by mabshoff) (diff)

The patches at #5954, #6037 and #6040 bring doctest coverage for quadratic forms up to 100%. In this patch series some functions were removed or renamed, so we should add compatibility functions.

These are the functions I propose we should handle:

  • count_modp__by_gauss_sum renamed to count_modp_solutions__by_Gauss_sum.
  • count_local_type was renamed to count_congruence_solutions.
  • count_local_good_type was renamed to count_congruence_solutions__good_type.
  • count_local_zero_type was renamed to count_congruence_solutions__zero_type.
  • count_local_bad_type was renamed to count_congruence_solutions__bad_type.
  • count_local_bad_typeI was renamed to count_congruence_solutions__bad_type_I.
  • count_local_bad_typeII was renamed to count_congruence_solutions__bad_type_II.
  • GHY_mass_maximal was renamed to GHY_mass__maximal.

Change History

comment:1 Changed 4 years ago by tornaria

Note, there are other functions which were removed, but most of them were not implemented, or wrongly implemented, badly or no documented, etc. It really makes no sense to keep them around.

comment:2 Changed 4 years ago by mabshoff

  • Owner changed from tbd to justin
  • Priority changed from major to blocker
  • Component changed from algebra to quadratic forms

comment:3 Changed 4 years ago by mabshoff

  • Description modified (diff)

comment:4 Changed 4 years ago by was

  • Milestone changed from sage-4.0 to sage-4.0.1

This isn't critical for 4.0.

comment:5 Changed 4 years ago by was

  • Status changed from new to closed
  • Resolution set to invalid

I don't see the point in doing this, since quadratic forms was only in Sage for a very short amount of time before making this API change.

Note: See TracTickets for help on using tickets.