Ticket #6052 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch; positive review] partial_fraction_decomposition is broken for irreducible denominators

Reported by: tornaria Owned by: tornaria
Priority: major Milestone: sage-4.0
Component: algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers: Mike Hansen
Authors: Gonzalo Tornaria Merged in: 4.0.rc0
Dependencies: Stopgaps:

Description 

19:34 < rickhg12hs> having some issues with partial fraction decomposition
19:37 < rickhg12hs> sage: R.<x> = GF(2)[];((x+1)/(x^3+x+1)).partial_fraction_decomposition()
19:37 < rickhg12hs> ... generates type errors
19:39 < rickhg12hs> sage: P.<y>=ZZ[];((y+1)/(y^2+y+1)).partial_fraction_decomposition()
19:39 < rickhg12hs> ... generates type errors also
19:41 < rickhg12hs> sage: ((y+1)/(y^2+y+1) + (y+1)/(y^2+1)).partial_fraction_decomposition()
19:41 < rickhg12hs> ... the line above works
19:43 < rickhg12hs> sage: ((x+1)/(x^3+x+1) + (x+1)/(x^3+x^2+1)).partial_fraction_decomposition()
19:43 < rickhg12hs> ... the line above works
19:46 < rickhg12hs> FYI:
19:46 < rickhg12hs> sage: version()
19:46 < rickhg12hs> 'Sage Version 3.4.2, Release Date: 2009-05-05'

Attachments

trac_6052.patch Download (2.6 KB) - added by mhansen 4 years ago.

Change History

comment:1 Changed 4 years ago by tornaria

  • Summary changed from partial_fraction_decomposition is broken for irreducible denominators to [with patch; needs review] partial_fraction_decomposition is broken for irreducible denominators

Changed 4 years ago by mhansen

comment:2 Changed 4 years ago by mhansen

  • Summary changed from [with patch; needs review] partial_fraction_decomposition is broken for irreducible denominators to [with patch; positive review] partial_fraction_decomposition is broken for irreducible denominators

Looks good to me. I just updated some minor Sphinx formatting issues in the patch.

Other than that, all tests pass and things look good to me.

comment:3 Changed 4 years ago by mabshoff

  • Milestone set to sage-4.0

comment:4 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 4.0.rc0.

Cheers,

Michael

comment:5 Changed 4 years ago by davidloeffler

  • Reviewers set to Mike Hansen
  • Merged in set to 4.0.rc0
  • Authors set to Gonzalo Tornaria
Note: See TracTickets for help on using tickets.