Ticket #6011 (closed enhancement: fixed)
[with patch, positive review] Bring plot/arrow.py to 100% coverage
| Reported by: | kcrisman | Owned by: | kcrisman |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-4.0 |
| Component: | documentation | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | Reviewers: | ||
| Authors: | Merged in: | ||
| Dependencies: | Stopgaps: |
Description
Bring plot/arrow.py to 100% coverage
Attachments
-
trac_6011.patch
(9.3 KB) -
added by kcrisman 4 years ago.
-
trac_6011-reviewer.patch
(1.6 KB) -
added by mvngu 4 years ago.
- reviewer patch; add consistency to the whole module
Change History
comment:1 Changed 4 years ago by kcrisman
- Owner changed from mabshoff to kcrisman
- Status changed from new to assigned
- Summary changed from Bring plot/arrow.py to 100% coverage to [with patch, needs review] Bring plot/arrow.py to 100% coverage
Also adds tiny plot3d enhancement (original doctest only tested Graphics.plot3d).
Please see http://groups.google.com/group/sage-devel/browse_thread/thread/1adac4035031b140/c36f1f8a7c8a9b43#c36f1f8a7c8a9b43 for why there is no loads(dumps()) test. Yet.
Changed 4 years ago by mvngu
-
attachment
trac_6011-reviewer.patch
added
reviewer patch; add consistency to the whole module
comment:3 Changed 4 years ago by mvngu
REFEREE REPORT
The patch trac_6011.patch applies OK against the "post-final" version sage-3.4.2, all doctests pass with the options -t -long, and the doctest coverage is now 100% as claimed. Note that sage/plot/arrow.py is not included in the reference manual, so you can't search for it in order to view the documentation for sage/plot/arrow.py.
The patch adds some trivial inconsistencies in how "two-dimensional" and "three-dimensional" are abbreviated. These and other inconsistencies are fixed in the reviewer patch trac_6011-reviewer.patch. Apart from the issue of consistency throughout the whole module, positive review for kcrisman's patch. Only my patch needs to be reviewed.
