Ticket #5927 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch; positive review] singular prompt problem on solaris sparc

Reported by: was Owned by: mhansen
Priority: blocker Milestone: sage-4.0
Component: porting Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Credit to William Stein, Mike Hansen, and Michael Abshoff?

Attachments

trac_5927.patch Download (2.7 KB) - added by mhansen 4 years ago.

Change History

comment:1 Changed 4 years ago by was

  • Summary changed from [with patch; needs review] singular prompt problem on solaris sparc to [with patch; positive review] singular prompt problem on solaris sparc

I tested it, and it works.

comment:2 Changed 4 years ago by was

  • Milestone changed from sage-4.0 to sage-3.4.2

comment:3 Changed 4 years ago by mabshoff

  • Summary changed from [with patch; positive review] singular prompt problem on solaris sparc to [with patch; needs work] singular prompt problem on solaris sparc

Oops, there are three doctest failures with this patch applied:

        sage -t -long devel/sage/sage/interfaces/expect.py # 1 doctests failed
        sage -t -long devel/sage/doc/en/developer/coding_in_other.rst # 2 doctests failed
        sage -t -long devel/sage/doc/en/constructions/algebraic_geometry.rst # 4 doctests failed

Cheers,

Michael

comment:4 Changed 4 years ago by mabshoff

  • Milestone changed from sage-4.0.1 to sage-4.0

This is a 4.0 blocker.

Mike: Any comments?

Cheers,

Michael

Changed 4 years ago by mhansen

comment:5 Changed 4 years ago by mhansen

  • Owner changed from mabshoff to mhansen
  • Status changed from new to assigned
  • Summary changed from [with patch; needs work] singular prompt problem on solaris sparc to [with patch; needs review] singular prompt problem on solaris sparc

All of the failures are harmless. I've attached a new patch which fixes the doctests.

comment:6 Changed 4 years ago by mabshoff

  • Summary changed from [with patch; needs review] singular prompt problem on solaris sparc to [with patch; positive review] singular prompt problem on solaris sparc

Hmm, I am not so sure the patch does fix every problem: Without the patch:

----------------------------------------------------------------------
| Sage Version 4.0.rc0, Release Date: 2009-05-21                     |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
sage: singular.eval("intvec G = 4,4,4,0,0,0;")
''

With the patch applied:

mabshoff@sage:/scratch/mabshoff/sage-4.0.rc1$ ./sage
----------------------------------------------------------------------
| Sage Version 4.0.rc0, Release Date: 2009-05-21                     |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
sage: singular.eval("intvec G = 4,4,4,0,0,0;")
'intvec G = 4,4,4,0,0,0;'
sage: 

If you look at the attached patch here it seems that we sometimes get the echo of the command and some times not. It might be consistent, i.e. the doctests pass on all platforms (I hope), but something still seems fishy.

I am not saying we shouldn't apply the patch since it fixes a much more severe bug, I just think that there is more to the story. Anyway, doctests do pass, so I will open a followup ticket and merge this patch.

Cheers,

Michael

comment:7 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 4.0.rc1.

Cheers,

Michael

Note: See TracTickets for help on using tickets.