Ticket #5878 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch; positive review] Add support for constructing irreducible matrix representations of the symmetric group

Reported by: saliola Owned by: mhansen
Priority: major Milestone: sage-4.1
Component: combinatorics Keywords: sage-combinat
Cc: sage-combinat Work issues:
Report Upstream: Reviewers: Mike Hansen
Authors: Franco Saliola Merged in: sage-4.1.alpha0
Dependencies: Stopgaps:

Description

It would be great to be able to construct the matrices for the irreducible representations of the symmetric group.

Attachments

trac_5878.patch Download (66.8 KB) - added by saliola 4 years ago.
trac_5878-review.patch Download (3.7 KB) - added by mhansen 4 years ago.

Change History

Changed 4 years ago by saliola

comment:1 Changed 4 years ago by saliola

  • Summary changed from Add support for constructing irreducible matrix representations of the symmetric group to [with patch; needs review] Add support for constructing irreducible matrix representations of the symmetric group

The patch adds functionality to construct Young's seminormal and orthogonal representations as well as the Specht representation. This is done via Yang-Baxter graphs, so the patch implements that as well.

comment:2 Changed 4 years ago by saliola

Warning: The patch depends on #5877.

But it doesn't have to though: #5877 fixes an issue that is required for the to_character method, and this method is not necessary for the rest of the code.

comment:3 follow-up: ↓ 4 Changed 4 years ago by mvngu

Using sage-4.0.alpha0 with patch from #6048, doctesting with options -t -long gave me BOOM!:

[mvngu@sage sage-4.0.alpha0]$ ./sage -t -long devel/sage-5878/sage/combinat/symmetric_group_representations.py
<LOTS_OF_BOOM!>

 Here's the full (but very long) error log from the doctests.

comment:4 in reply to: ↑ 3 Changed 4 years ago by saliola

Replying to mvngu:

Using sage-4.0.alpha0 with patch from #6048, doctesting with options -t -long gave me BOOM!:

I can't reproduce this. When I run the tests, with or without #6048, I get no failures:

karkwa: sage-4.0 -version
| Sage Version 4.0.alpha0, Release Date: 2009-05-15                  |

karkwa: hg qapplied 
non-ascii.patch
trac_5878.patch

karkwa: sage-4.0 -b && sage-4.0 -t -long symmetric_group_representations.py yang_baxter_graph.py 
...
real    0m1.263s
user    0m1.004s
sys     0m0.244s
sage -t -long "devel/sage-main/sage/combinat/symmetric_group_representations.py"
         [5.8 s]
sage -t -long "devel/sage-main/sage/combinat/yang_baxter_graph.py"
         [3.4 s]
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 9.2 seconds

Can you re-check this?

Thanks, Franco

Changed 4 years ago by mhansen

comment:5 follow-up: ↓ 6 Changed 4 years ago by mhansen

  • Owner changed from saliola to mhansen
  • Status changed from new to assigned

Things look good to me after I've applied my reviewer patch which takes care of the issues with the upgrade to 4.0.

Franco, can you just check over these?

comment:6 in reply to: ↑ 5 Changed 4 years ago by saliola

Replying to mhansen:

Things look good to me after I've applied my reviewer patch which takes care of the issues with the upgrade to 4.0.

Franco, can you just check over these?

Checked. They are correct.

Positive review for the reviewer patch.

comment:7 Changed 4 years ago by mvngu

So all patches have proper review? If so, then the summary should be changed.

comment:8 Changed 4 years ago by ncalexan

  • Reviewers set to Mike Hansen
  • Authors set to Franco Saliola

Patch looks good, tests pass on sage.math and my OS X 10.5 laptop. I'm not expert enough to say the code is correct. Is this positive review?

comment:9 Changed 4 years ago by boothby

  • Summary changed from [with patch; needs review] Add support for constructing irreducible matrix representations of the symmetric group to [with patch; positive review] Add support for constructing irreducible matrix representations of the symmetric group

This is ridiculous. Mhansen gave it a positive review pending saliola's opinion. Saliola confirmed mhansen's review and +1'd mhansen's patch. I'm merging this one.

comment:10 Changed 4 years ago by rlm

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Merged in set to sage-4.1.alpha0
Note: See TracTickets for help on using tickets.