Ticket #5872 (closed defect: fixed)

Opened 11 months ago

Last modified 8 months ago

[with patch, positive review] Explicitly pass -fPIC into ntl shared object build.

Reported by: pjeremy Owned by: mhansen
Priority: major Milestone: sage-4.1
Component: freebsd Keywords:
Cc: Author(s): Peter Jeremy
Report Upstream: Reviewer(s): Mike Hansen
Merged in: sage-4.1.rc0 Work issues:

Description

The ntl makefile appears to rely on compiler flags specified as a target dependency being passed to the compiler. This fails on at least FreeBSD, resulting in an attempt to include non-PIC objects in a shared library.

Instead, explicitly pass -fPIC to the sub-make used for the shared object build.

Attachments

ntl-5.4.2.p6.patch Download (0.5 KB) - added by pjeremy 11 months ago.

Change History

Changed 11 months ago by pjeremy

Changed 9 months ago by mhansen

  • owner changed from mabshoff to mhansen
  • reviewer set to Mike Hansen
  • summary changed from [with patch, needs review] Explicitly pass -fPIC into ntl shared object build. to [with patch, positive review] Explicitly pass -fPIC into ntl shared object build.
  • status changed from new to assigned
  • author set to Peter Jeremy

Looks good to me.

The spkg incorporating this patch can be found at  http://sage.math.washington.edu/home/mhansen/ntl-5.4.2.p8.spkg

Changed 8 months ago by rlm

  • status changed from assigned to closed
  • resolution set to fixed
  • merged set to sage-4.1.rc0
Note: See TracTickets for help on using tickets.