Ticket #5866 (closed defect: fixed)

Opened 11 months ago

Last modified 8 months ago

[with patch, positive review] Fix freetype build on systems where make is not GNU make.

Reported by: pjeremy Owned by: mhansen
Priority: major Milestone: sage-4.1
Component: freebsd Keywords:
Cc: Author(s): Peter Jeremy
Report Upstream: Reviewer(s): Mike Hansen
Merged in: sage-4.1.rc0 Work issues:

Description

Change 'make' to ${MAKE} - is the recommended way to recursively invoke make to ensure that the subordinate make is the same as the parent make (and also ensures that the two make instances will communicate on things like '-jX').

Explicitly export the parent make into the configure script.

These changes avoid problems on systems like FreeBSD where make is not GNU make.

Attachments

freetype-2.3.5.p0.patch Download (441 bytes) - added by pjeremy 11 months ago.

Change History

Changed 11 months ago by pjeremy

Changed 11 months ago by mabshoff

  • summary changed from Fix freetype build on systems where make is not GNU make. to [with patch, needs review] Fix freetype build on systems where make is not GNU make.
  • milestone set to sage-3.4.2

I will work on integrating this tomorrow.

Cheers,

Michael

Changed 9 months ago by mhansen

  • owner changed from mabshoff to mhansen
  • reviewer set to Mike Hansen
  • summary changed from [with patch, needs review] Fix freetype build on systems where make is not GNU make. to [with patch, positive review] Fix freetype build on systems where make is not GNU make.
  • status changed from new to assigned
  • author set to Peter Jeremy

Looks good to me.

The spkg with this change incorporated can be found at  http://sage.math.washington.edu/home/mhansen/freetype-2.3.5.p1.spkg

Changed 8 months ago by rlm

  • status changed from assigned to closed
  • resolution set to fixed
  • merged set to sage-4.1.rc0
Note: See TracTickets for help on using tickets.