Ticket #5857 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] E.list() for E an elliptic curve over a finite field is broken

Reported by: was Owned by: davidloeffler
Priority: major Milestone: sage-4.1.2
Component: elliptic curves Keywords:
Cc: Work issues:
Report Upstream: Reviewers: Alex Ghitza, Minh Van Nguyen
Authors: John Cremona Merged in: Sage 4.1.2.alpha0
Dependencies: Stopgaps:

Description

E.list() doesn't work, but list(E) works fine. 

sage: E = EllipticCurve(GF(11), [1,2])
sage: E.list()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)

/Users/wstein/.sage/temp/teragon.local/15239/_Users_wstein__sage_init_sage_0.py in <module>()

/Users/wstein/build/sage-3.4.1/local/lib/python2.5/site-packages/sage/structure/parent.so in sage.structure.parent.Parent.list (sage/structure/parent.c:5196)()

AttributeError: 'EllipticCurve_finite_field' object has no attribute '__iter__'
sage: list(E)

[(0 : 1 : 0),
 (1 : 2 : 1),
 (1 : 9 : 1),
 (2 : 1 : 1),
...

See also #5856

Attachments

trac_5857-elliptic_curve_iterator.patch Download (1.3 KB) - added by cremona 4 years ago.
Applies to 4.1.1
trac_5857-reviewer.patch Download (942 bytes) - added by mvngu 4 years ago.
reviewer patch

Change History

comment:1 Changed 4 years ago by davidloeffler

  • Owner changed from was to davidloeffler
  • Component changed from number theory to elliptic curves

Changed 4 years ago by cremona

Applies to 4.1.1

comment:2 Changed 4 years ago by cremona

  • Summary changed from E.list() for E an elliptic curve over a finite field is broken to [with patch, needs review] E.list() for E an elliptic curve over a finite field is broken
  • Authors set to John Cremona

I think this does what was wanted.

comment:3 Changed 4 years ago by AlexGhitza

  • Reviewers set to Alex Ghitza
  • Summary changed from [with patch, needs review] E.list() for E an elliptic curve over a finite field is broken to [with patch, positive review] E.list() for E an elliptic curve over a finite field is broken

Looks good.

Changed 4 years ago by mvngu

reviewer patch

comment:4 Changed 4 years ago by mvngu

  • Status changed from new to closed
  • Reviewers changed from Alex Ghitza to Alex Ghitza, Minh Van Nguyen
  • Resolution set to fixed
  • Merged in set to Sage 4.1.2.alpha0

The reviewer patch trac_5857-reviewer.patch fixes a trivial typo in ReST formatting. Merged patches in this order:

  1. trac_5857-elliptic_curve_iterator.patch
  2. trac_5857-reviewer.patch
Note: See TracTickets for help on using tickets.