Ticket #5851 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] Convert 3 more elliptic curves files to ReST and add to reference manual

Reported by: cremona Owned by: was
Priority: minor Milestone: sage-3.4.2
Component: number theory Keywords: elliptic curve documentation
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

The patch fully ReST-ifies the files

  • ell_field.py
  • ec_database.py
  • kodaira_symbol.py

in sage/schemes/elliptic_curves, and adds them to the reference manual.

These are all quite short and simple. The patch is based on 3.4.1.rc4.

Attachments

ecdocs3.patch Download (14.9 KB) - added by cremona 4 years ago.

Change History

Changed 4 years ago by cremona

comment:1 Changed 4 years ago by wuthrich

John, at home I manage to produce the correct html output and all tests passed. I am quite certain the patch is ok, but a 50% success rate is maybe too low. So I am going back to see what went wrong in my office.

comment:2 Changed 4 years ago by wuthrich

  • Summary changed from [with patch, needs review] Convert 3 more elliptic curves files to ReST and add to reference manual to [with patch, positive review] Convert 3 more elliptic curves files to ReST and add to reference manual

OK. Now it works on my office installation of sage, too. I can not reproduce the earlier error and hence I can give a positive review.

This issues of this trac, namely to improve the documentation of elliptic curves, continues in trac #5853.

comment:3 Changed 4 years ago by cremona

Good, I'm glad the problems went away!

comment:4 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.4.2.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.