Ticket #5825 (closed defect: fixed)

Opened 4 years ago

Last modified 4 weeks ago

sage -i $FOO.spkg should abort cleanly when write permissions are lacking

Reported by: mabshoff Owned by: mabshoff
Priority: major Milestone: sage-5.10
Component: scripts Keywords:
Cc: jhpalmieri Work issues:
Report Upstream: N/A Reviewers: John Palmieri
Authors: Jeroen Demeyer Merged in: sage-5.10.beta5
Dependencies: Stopgaps:

Description (last modified by jdemeyer) (diff)

Fix sage-spkg to give a useful error message if SAGE_PACKAGES or SAGE_BUILD_DIR or SAGE_LOCAL isn't writable, while still allowing sage --info to work without write access.

Apply 5825_install_perm.patch Download to SAGE_ROOT.

Attachments

5825_install_perm.patch Download (3.3 KB) - added by jdemeyer 4 weeks ago.

Change History

comment:1 Changed 5 weeks ago by jdemeyer

  • Status changed from new to needs_review
  • Description modified (diff)
  • Authors set to Jeroen Demeyer
  • Cc jhpalmieri added
  • Component changed from packages: standard to scripts
  • Report Upstream set to N/A

comment:2 Changed 4 weeks ago by jhpalmieri

Is it worth checking permissions before attempting to download an spkg? 

$ sage -i pybtex
tee: /Users/palmieri/Desktop/Sage_stuff/sage_builds/sage-5.10.beta4/logs/install.log: Permission denied
tee: /Users/palmieri/Desktop/Sage_stuff/sage_builds/sage-5.10.beta4/logs/pkgs/pybtex.log: Permission denied
Attempting to download package pybtex
>>> Checking online list of optional packages.
[.]
>>> Found pybtex-20120618
>>> Downloading http://www.sagemath.org/spkg/optional/pybtex-20120618.spkg.
/Users/palmieri/Desktop/Sage_stuff/sage_builds/sage-5.10.beta4/spkg/bin/sage-spkg: line 354: pybtex-20120618.tmp: Permission denied
Error: failed to download package pybtex-20120618

This is not as nice an error message as you added in other situations: 

$ sage -f gcc
tee: /Users/palmieri/Desktop/Sage_stuff/sage_builds/sage-5.10.beta4/logs/install.log: Permission denied
tee: /Users/palmieri/Desktop/Sage_stuff/sage_builds/sage-5.10.beta4/logs/pkgs/gcc.log: Permission denied
Found package gcc in spkg/standard/gcc-4.7.3.p0.spkg
Error: no write access to build directory /Users/palmieri/Desktop/Sage_stuff/sage_builds/sage-5.10.beta4/spkg/build.

Changed 4 weeks ago by jdemeyer

comment:3 Changed 4 weeks ago by jdemeyer

OK, fixed.

comment:4 Changed 4 weeks ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 4 weeks ago by jhpalmieri

  • Status changed from needs_review to positive_review
  • Reviewers set to John Palmieri

Great, looks good.

comment:6 Changed 4 weeks ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.10.beta5
Note: See TracTickets for help on using tickets.