Ticket #5815 (closed defect: fixed)
[with patch, positive review] Disable TinyMCE in the live documentation
| Reported by: | mpatel | Owned by: | boothby |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-3.4.2 |
| Component: | notebook | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | Reviewers: | ||
| Authors: | Merged in: | ||
| Dependencies: | Stopgaps: |
Description
Double-clicking on a text cell in the live documentation --- I've done this accidentally several times --- fires up TinyMCE, which acts strangely. More importantly, no changes will be saved, as Jason Grout pointed out on sage-devel:
http://groups.google.com/group/sage-devel/browse_thread/thread/8c8fe7c5d0c0f725
Attachments
-
trac_5815_tinymce_live_doc.patch
(899 bytes) -
added by mpatel 4 years ago.
- See the comment.
-
trac-5815-docs-and-tinymce.patch
(1.0 KB) -
added by jason 4 years ago.
- apply instead of previous patch.
Change History
Changed 4 years ago by mpatel
-
attachment
trac_5815_tinymce_live_doc.patch
added
comment:1 Changed 4 years ago by mpatel
The new line of code, like the CSS "hack" which follows it, depends, I think, on an exact match.
Perhaps it's better to add code which disables editing.
comment:2 Changed 4 years ago by jason
I agree that the above patch is the wrong solution. I'll post a patch momentarily which disables it just like when the sheet is published.
Changed 4 years ago by jason
-
attachment
trac-5815-docs-and-tinymce.patch
added
apply instead of previous patch.
comment:3 Changed 4 years ago by jason
trac-5815-docs-and-tinymce.patch takes care of this issue by implementing the idea from the comment above (i.e., don't put the TinyMCE trigger in when you are looking at a doc page).
mpatel, can you review this patch?
comment:4 follow-up: ↓ 5 Changed 4 years ago by mpatel
- Summary changed from [with patch, needs review] Disable TinyMCE in the live documentation to [with patch, positive review] Disable TinyMCE in the live documentation
The new patch works and is definitely better than the first.
I noticed that copying or printing a docbrowser worksheet omits Sphinx' stylesheet. One-cell mode also appears to be broken. Of course, these are separate issues, and I can open new tickets.
comment:5 in reply to: ↑ 4 Changed 4 years ago by mpatel
Replying to mpatel:
I noticed that copying or printing a docbrowser worksheet omits Sphinx' stylesheet. One-cell mode also appears to be broken. Of course, these are separate issues, and I can open new tickets.
Oops! One-cell mode is fine. Sorry.
See the comment.