Ticket #5805 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, with positive review] Sage 3.4.1.rc3: numerical noise in "devel/sage/sage/modular/dirichlet.py"

Reported by: jsp Owned by: mabshoff
Priority: blocker Milestone: sage-3.4.1
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

On Fedora 9, 32 bit: 

sage -t  "devel/sage/sage/modular/dirichlet.py"             
**********************************************************************
File "/home/jaap/downloads/sage-3.4.1.rc0/devel/sage/sage/modular/dirichlet.py", line 1044:
    sage: e.kloosterman_sum_numerical()
Expected:
    7.21644966006e-16 + 1.73205080757*I
Got:
    6.66133814775e-16 + 1.73205080757*I
**********************************************************************
1 items had failures:
   1 of   8 in __main__.example_29
***Test Failed*** 1 failures.

Cheers,

Jaap

Attachments

trac_5805.patch Download (988 bytes) - added by mabshoff 4 years ago.

Change History

comment:1 Changed 4 years ago by mabshoff

  • Owner changed from craigcitro to mabshoff
  • Status changed from new to assigned
  • Component changed from modular forms to doctest

Another datapoint from 3.4.1.rc3 on Solaris 10/x86-64 running in 32 bit mode: 

sage -t -long devel/sage/sage/modular/dirichlet.py
**********************************************************************
File "/home/mabshoff/build-3.4.1.rc2/sage-3.4.1.rc2-fulvia-gcc-4.3.3/
devel/sage-main/sage/modular/dirichlet.py", line 10
44:
    sage: e.kloosterman_sum_numerical()
Expected:
    7.21644966006e-16 + 1.73205080757*I
Got:
    6.66133814775e-16 + 1.73205080757*I
**********************************************************************

comment:2 Changed 4 years ago by mabshoff

  • Priority changed from major to blocker
  • Summary changed from numerical noise in "devel/sage/sage/modular/dirichlet.py" to Sage 3.4.1.rc3: numerical noise in "devel/sage/sage/modular/dirichlet.py"

Add the Sage release, make it clear it is a blocker.

Cheers,

Michael

Changed 4 years ago by mabshoff

comment:3 Changed 4 years ago by mabshoff

  • Summary changed from Sage 3.4.1.rc3: numerical noise in "devel/sage/sage/modular/dirichlet.py" to [with patch, needs review] Sage 3.4.1.rc3: numerical noise in "devel/sage/sage/modular/dirichlet.py"

comment:4 Changed 4 years ago by cremona

  • Summary changed from [with patch, needs review] Sage 3.4.1.rc3: numerical noise in "devel/sage/sage/modular/dirichlet.py" to [with patch, with positive review] Sage 3.4.1.rc3: numerical noise in "devel/sage/sage/modular/dirichlet.py"

Patch looks good to me, applied ok to 3.4.1.rc3 and passed test on 32- and 64-bit.

comment:5 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 3.4.1.rc4.

Cheers,

Michael

Note: See TracTickets for help on using tickets.