Ticket #5743 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, with positive review] Solaris 10/Sparc: Fix numerical noise issues in doctests

Reported by: mabshoff Owned by: mabshoff
Priority: critical Milestone: sage-3.4.1
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

There are a couple doctests on Solaris 10/Sparc that fail due to numerical noise. Fix it.

A patch is coming up.

Cheers,

Michael

Attachments

trac_5743.patch Download (1.7 KB) - added by mabshoff 4 years ago.

Change History

comment:1 Changed 4 years ago by mabshoff

  • Status changed from new to assigned

Changed 4 years ago by mabshoff

comment:2 Changed 4 years ago by mabshoff

  • Summary changed from Solaris 10/Sparc: Fix numerical noise issues in doctests to [with patch, needs review] Solaris 10/Sparc: Fix numerical noise issues in doctests

This patch fixes the following two doctest failures on Solaris 10/Sparc:

sage -t  "devel/sage/sage/modules/free_module_element.pyx"  
**********************************************************************
File "/home/mabshoff/build-3.4.1.rc1/sage-3.4.1.rc1-mark-gcc-4.3.3/devel/sage/sage/modules/free_module_element.pyx", line 505:
    sage: vector(RDF, {1:pi, 1000:e})._sage_input_(SageInputBuilder(), False)
Expected:
    {call: {atomic:vector}({atomic:RDF}, {dict: {{atomic:1}:{atomic:3.1415926535897931}, {atomic:1000}:{atomic:2.7182818284590451}}})}
Got:
    {call: {atomic:vector}({atomic:RDF}, {dict: {{atomic:1}:{atomic:3.1415926535897931}, {atomic:1000}:{atomic:2.7182818284590455}}})}
**********************************************************************
1 items had failures:
   1 of  10 in __main__.example_8

and

sage -t  "devel/sage/sage/rings/real_double.pyx"            
**********************************************************************
File "/home/mabshoff/build-3.4.1.rc1/sage-3.4.1.rc1-mark-gcc-4.3.3/devel/sage/sage/rings/real_double.pyx", line 727:
    sage: sage_input(RDF(-e), verify=True, preparse=False)
Expected:
    # Verified
    -RDF(2.7182818284590451)
Got:
    # Verified
    -RDF(2.7182818284590455)
**********************************************************************

Cheers,

Michael

comment:3 Changed 4 years ago by craigcitro

  • Summary changed from [with patch, needs review] Solaris 10/Sparc: Fix numerical noise issues in doctests to [with patch, with positive review] Solaris 10/Sparc: Fix numerical noise issues in doctests

Yep, that's some numerical noise.

comment:4 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 3.4.1.rc3.

Cheers,

Michael

Note: See TracTickets for help on using tickets.