Ticket #5729 (closed enhancement: fixed)
[with patch, positive review] Cleanup of crystal code: cartan_type now a method rather than attribute
| Reported by: | aschilling | Owned by: | aschillin |
|---|---|---|---|
| Priority: | major | Milestone: | sage-3.4.1 |
| Component: | combinatorics | Keywords: | |
| Cc: | sage-combinat | Work issues: | |
| Report Upstream: | Reviewers: | ||
| Authors: | Merged in: | ||
| Dependencies: | Stopgaps: |
Description (last modified by nthiery) (diff)
Crystals: cartan_type is a method
- Changed the API to have cartan type as a method rather than attribute
- Systematically use .parent() instead of ._parent
- Minor doc improvements
Attachments
Change History
Changed 4 years ago by aschilling
-
attachment
crystal-5729-track.patch
added
changed according to Nicolas' suggestions
comment:1 Changed 4 years ago by aschilling
- Summary changed from Cleanup of crystal code: cartan_type now a method rather than attribute to [with patch, needs review] Cleanup of crystal code: cartan_type now a method rather than attribute
comment:2 Changed 4 years ago by nthiery
- Cc sage-combinat added
- Summary changed from [with patch, needs review] Cleanup of crystal code: cartan_type now a method rather than attribute to [with patch, positive review] Cleanup of crystal code: cartan_type now a method rather than attribute
Final version of the patch uploaded:
- fixes 2/3 remaining calls to parent()
- Micro doc improvements
comment:4 Changed 4 years ago by aschilling
- Status changed from new to closed
- Resolution set to fixed
Note: See
TracTickets for help on using
tickets.
