Ticket #5729 (closed enhancement: fixed)

Opened 11 months ago

Last modified 11 months ago

[with patch, positive review] Cleanup of crystal code: cartan_type now a method rather than attribute

Reported by: aschilling Owned by: aschillin
Priority: major Milestone: sage-3.4.1
Component: combinatorics Keywords:
Cc: sage-combinat Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description (last modified by nthiery) (diff)

Crystals: cartan_type is a method

  • Changed the API to have cartan type as a method rather than attribute
  • Systematically use .parent() instead of ._parent
  • Minor doc improvements

Attachments

crystal-cleanup-track.patch Download (18.1 KB) - added by aschilling 11 months ago.
crystal-5729-track.patch Download (27.4 KB) - added by aschilling 11 months ago.
changed according to Nicolas' suggestions
crystal-5729-track.2.patch Download (30.7 KB) - added by nthiery 11 months ago.

Change History

Changed 11 months ago by aschilling

Changed 11 months ago by aschilling

changed according to Nicolas' suggestions

Changed 11 months ago by aschilling

  • summary changed from Cleanup of crystal code: cartan_type now a method rather than attribute to [with patch, needs review] Cleanup of crystal code: cartan_type now a method rather than attribute

Changed 11 months ago by nthiery

Changed 11 months ago by nthiery

  • cc sage-combinat added
  • summary changed from [with patch, needs review] Cleanup of crystal code: cartan_type now a method rather than attribute to [with patch, positive review] Cleanup of crystal code: cartan_type now a method rather than attribute

Final version of the patch uploaded:

  • fixes 2/3 remaining calls to parent()
  • Micro doc improvements

Changed 11 months ago by nthiery

  • description modified (diff)

Changed 11 months ago by aschilling

  • status changed from new to closed
  • resolution set to fixed

Changed 11 months ago by mabshoff

  • status changed from closed to reopened
  • resolution fixed deleted

Huh? This ticket has not been merged.

Cheers,

Michael

Changed 11 months ago by mabshoff

  • status changed from reopened to closed
  • resolution set to fixed

Merged crystal-5729-track.2.patch in Sage 3.4.1.rc2.

Cheers,

Michael

Note: See TracTickets for help on using tickets.