Ticket #5695 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] Sage 3.4.1.rc1: doctest failure in combinat/words/words.py on 32 bit boxen

Reported by: mabshoff Owned by: mabshoff
Priority: blocker Milestone: sage-3.4.1
Component: doctest coverage Keywords:
Cc: hivert, saliola Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

This looks like fallout from #5308: 

sage -t -long "devel/sage/sage/combinat/words/words.py"     
**********************************************************************
File "/Users/mabshoff/sage-3.4.1.rc1/devel/sage/sage/combinat/words/words.py", line 760:
    sage: Words(7,13).cardinality()
Expected:
    96889010407L               
Got:
    96889010407
**********************************************************************
File "/Users/mabshoff/sage-3.4.1.rc1/devel/sage/sage/combinat/words/words.py", line 763:
    sage: Words(['a','b','c','d','e','f','g'],13).cardinality()
Expected:
    96889010407L               
Got:
    96889010407
**********************************************************************
1 items had failures:
   2 of  12 in __main__.example_31
***Test Failed*** 2 failures.
For whitespace errors, see the file /Users/mabshoff/sage-3.4.1.rc1/tmp/.doctest_words.py
	 [18.4 s]
exit code: 1024

Trivial patch coming up.

Cheers,

Michael

Attachments

trac_5695.patch Download (984 bytes) - added by mabshoff 4 years ago.

Change History

Changed 4 years ago by mabshoff

comment:1 Changed 4 years ago by mabshoff

  • Cc hivert, saliola added
  • Status changed from new to assigned
  • Summary changed from Sgae 3.4.1.rc1: doctest failure in combinat/words/words.py on 32 bit boxen to [with patch, needs review] Sage 3.4.1.rc1: doctest failure in combinat/words/words.py on 32 bit boxen

Franco or Florent, since either one of you broke this in #5308 feel free to review this trivial and obvious patch :P

Cheers,

Michael

comment:2 Changed 4 years ago by jsp

  • Summary changed from [with patch, needs review] Sage 3.4.1.rc1: doctest failure in combinat/words/words.py on 32 bit boxen to [with patch, positive review] Sage 3.4.1.rc1: doctest failure in combinat/words/words.py on 32 bit boxen

OK, I don't want Franco or Florent to be offended.

But this patch is trivial and obvious.

Positive review :)

Jaap

comment:3 Changed 4 years ago by hivert

Oops !!! I solved the problem in #5308 but it seems I completely forgot to update the doctests in words ! One hundred apologies.

By the way since it is not yet merged I can also add my positive review :)

Florent

comment:4 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 3.4.1.rc2.

Cheers,

Michael

Note: See TracTickets for help on using tickets.