Ticket #5636 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch; positive review] %jsmath in the notebook is broken in sage-3.4

Reported by: was Owned by: cwitty
Priority: major Milestone: sage-3.4.1
Component: misc Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

On Sun, Mar 29, 2009 at 3:39 PM, John H Palmieri wrote:
>
> 1. In sage-3.4, it looks like %jsmath is broken.  Can anyone reproduce
> this?
>
> Since I haven't seen anyone mention this, either I missed it or no one
> uses %jsmath any more.  So is it worth fixing, or should we scrap it
> (and just use tinyMCE, %html, %latex, etc.)?

I just fixed it.  It took me 1 minute (since it was my fault it was broken in the first place -- I broke this in 3.3).

Attachments

trac_5636.patch Download (709 bytes) - added by was 4 years ago.

Change History

comment:1 Changed 4 years ago by was

  • Summary changed from [with patch; needs review] jsmath is broken in sage-3.4 to [with patch; needs review] %jsmath in the notebook is broken in sage-3.4

Changed 4 years ago by was

comment:2 Changed 4 years ago by jhpalmieri

  • Summary changed from [with patch; needs review] %jsmath in the notebook is broken in sage-3.4 to [with patch; positive review] %jsmath in the notebook is broken in sage-3.4

Fixes the problem, simple code, all tests pass. Positive review.

comment:3 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.4.1.rc0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.