Ticket #5629 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] refactor dimension() of schemes

Reported by: AlexGhitza Owned by: AlexGhitza
Priority: major Milestone: sage-3.4.1
Component: algebraic geometry Keywords: dimension scheme
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

The dimension() method for schemes is confusing and sometimes inconsistent or plain broken when working over bases that are not fields. The attached patch implements methods dimension_absolute() and dimension_relative() and makes dimension() into an alias for dimension_absolute().

Attachments

trac_5629.patch Download (10.7 KB) - added by AlexGhitza 4 years ago.
trac_5629-rebase.patch Download (10.8 KB) - added by was 4 years ago.
rebased against 3.4.1.alpha0 and added a missing doctst

Change History

Changed 4 years ago by AlexGhitza

comment:1 Changed 4 years ago by AlexGhitza

See the following thread for more details:

 http://groups.google.com/group/sage-devel/browse_thread/thread/cab22c1376251540

comment:2 Changed 4 years ago by AlexGhitza

  • Summary changed from refactor dimension() of schemes to [with patch, needs review] refactor dimension() of schemes

comment:3 Changed 4 years ago by AlexGhitza

  • Owner changed from was to AlexGhitza

comment:4 Changed 4 years ago by AlexGhitza

  • Status changed from new to assigned

comment:5 Changed 4 years ago by was

REFEREE REPORT.

Looks great. I rebased this patch against 3.4.1.alpha0 and added a doctest for the following new function. I also doctested this patch against the schemes directory. 

 	137	    def is_noetherian(self): 
 	138	        """ 
 	139	        Return True if this scheme is Noetherian. 
 	140	        """ 
 	141	        return self.__R.is_noetherian()

Changed 4 years ago by was

rebased against 3.4.1.alpha0 and added a missing doctst

comment:6 Changed 4 years ago by was

  • Summary changed from [with patch, needs review] refactor dimension() of schemes to [with patch, positive review] refactor dimension() of schemes

comment:7 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged trac_5629-rebase.patch in Sage 3.4.1.rc0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.