Ticket #5593 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch; positive review] CremonaDB.conductor_range does not give a Python style range

Reported by: nbruin Owned by: nbruin
Priority: minor Milestone: sage-3.4.1
Component: modular forms Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

CremonaDB().conductor_range() gives an inclusive upper bound, so that srange(*CremonaDB().conductor_range()) may miss a conductor.

Fix attached

Attachments

11804.patch Download (956 bytes) - added by nbruin 4 years ago.
Patch

Change History

Changed 4 years ago by nbruin

Patch

comment:1 Changed 4 years ago by robertwb

  • Summary changed from [with patch; needs review or throwing away] CremonaDB.conductor_range does not give a Python style range to [with patch; positive review] CremonaDB.conductor_range does not give a Python style range

Yes, this looks like the right thing to do.

comment:2 Changed 4 years ago by cremona

Looks good to me too.

comment:3 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.4.1.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.