Ticket #5575 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch; with positive review] bug in span

Reported by: was Owned by: was
Priority: major Milestone: sage-3.4.1
Component: linear algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

sage: V = QQ^4
sage: a = [V.random_element() for _ in range(4)]
sage: span(a)
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)

/Users/wstein/.sage/temp/teragon.local/19499/_Users_wstein__sage_init_sage_0.py in <module>()

/Users/wstein/build/sage-3.4/local/lib/python2.5/site-packages/sage/modules/free_module.pyc in span(gens, base_ring, check, already_echelonized)
    456         base_ring, gens = gens, base_ring
    457         
--> 458     R = self.base_ring() if base_ring is None else base_ring
    459 
    460     if not isinstance(R, principal_ideal_domain.PrincipalIdealDomain):

NameError: global name 'self' is not defined

Attachments

trac_5575.patch Download (1.2 KB) - added by was 4 years ago.

Change History

Changed 4 years ago by was

comment:1 Changed 4 years ago by was

  • Summary changed from bug in span to [with patch; needs review] bug in span

comment:2 Changed 4 years ago by cremona

  • Summary changed from [with patch; needs review] bug in span to [with patch; with positive review] bug in span

Review: patch looks fine and applies ok to 3.4. There is an appropriate doctest and all tests in sage/modules pass. Good!

comment:3 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.4.1.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.