Ticket #5526 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch; positive review] get rid of including sse4_1 in local/lib/sage-flags.txt

Reported by: was Owned by: mabshoff
Priority: blocker Milestone: sage-3.4.1
Component: distribution Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description (last modified by was) (diff)

Justification: evidently we don't use this and it's on our box that builds binaries.

The attached patch refactors the code in sage-location slightly to only *include* known flags we care about.

Attachments

trac-local_bin_repo-5526.patch Download (1.3 KB) - added by was 4 years ago.

Change History

comment:1 Changed 4 years ago by was

  • Description modified (diff)

comment:2 Changed 4 years ago by was

  • Summary changed from get rid of including sse4_1 in local/lib/sage-flags.txt to [with patch; needs review] get rid of including sse4_1 in local/lib/sage-flags.txt

Changed 4 years ago by was

comment:3 Changed 4 years ago by mabshoff

  • Summary changed from [with patch; needs review] get rid of including sse4_1 in local/lib/sage-flags.txt to [with patch; positive review] get rid of including sse4_1 in local/lib/sage-flags.txt

I can live with this patch. We do not technically need the 'ssse3' flag since the Sage library does not use it.

Cheers,

Mihcael

comment:4 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.4.1.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.