Ticket #5495 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] fix typo in error: "A mysterious error (perphaps a memory error?)" *PERP*HAPS!!!

Reported by: was Owned by: jhpalmieri
Priority: major Milestone: sage-3.4.1
Component: misc Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

There is a typo in the error message below (not a "perp"haps): 

wstein@debian32:/space/wstein/farm/sage-3.4/devel/sage/sage/matrix$ sage -t matrix2.pyx
sage -t  "devel/sage-main/sage/matrix/matrix2.pyx"          
*** glibc detected *** double free or corruption (fasttop): 0x0a41a380 ***
A mysterious error (perphaps a memory error?) occurred, which may have crashed doctest.
	 [2.4 s]

Attachments

5495.patch Download (759 bytes) - added by jhpalmieri 4 years ago.

Change History

comment:1 Changed 4 years ago by was

  • Summary changed from type: "A mysterious error (perphaps a memory error?)" *PERP*HAPS!!! to fix typo in error: "A mysterious error (perphaps a memory error?)" *PERP*HAPS!!!

comment:2 Changed 4 years ago by jhpalmieri

  • Owner changed from cwitty to jhpalmieri
  • Status changed from new to assigned
  • Summary changed from fix typo in error: "A mysterious error (perphaps a memory error?)" *PERP*HAPS!!! to [with patch, needs review] fix typo in error: "A mysterious error (perphaps a memory error?)" *PERP*HAPS!!!

Trivial patch.

Changed 4 years ago by jhpalmieri

comment:3 Changed 4 years ago by mvngu

  • Summary changed from [with patch, needs review] fix typo in error: "A mysterious error (perphaps a memory error?)" *PERP*HAPS!!! to [with patch, needs work] fix typo in error: "A mysterious error (perphaps a memory error?)" *PERP*HAPS!!!

The patch 5495.patch fails to apply at all against Sage 3.4: 

sage: hg_sage.apply("/home/mvngu/patch/5495/5495.patch")
cd "/home/mvngu/scratch/sage-3.4/devel/sage" && hg status
cd "/home/mvngu/scratch/sage-3.4/devel/sage" && hg status
cd "/home/mvngu/scratch/sage-3.4/devel/sage" && hg import   "/home/mvngu/patch/5495/5495.patch"
applying /home/mvngu/patch/5495/5495.patch
unable to find 'sage-doctest' for patching
1 out of 1 hunks FAILED -- saving rejects to file sage-doctest.rej
abort: patch failed to apply

comment:4 follow-up: ↓ 6 Changed 4 years ago by jhpalmieri

Try using "hg_scripts" instead of "hg_sage".

comment:5 Changed 4 years ago by jhpalmieri

  • Summary changed from [with patch, needs work] fix typo in error: "A mysterious error (perphaps a memory error?)" *PERP*HAPS!!! to [with patch, needs review] fix typo in error: "A mysterious error (perphaps a memory error?)" *PERP*HAPS!!!

comment:6 in reply to: ↑ 4 Changed 4 years ago by mvngu

  • Summary changed from [with patch, needs review] fix typo in error: "A mysterious error (perphaps a memory error?)" *PERP*HAPS!!! to [with patch, positive review] fix typo in error: "A mysterious error (perphaps a memory error?)" *PERP*HAPS!!!

Replying to jhpalmieri:

Try using "hg_scripts" instead of "hg_sage".


Yep, it now applies OK against Sage 3.4. Looks good, and I doctested sage/matrix/matrix2.pyx hoping to get a similar error as reported above. But no "mysterious error" popped up. Anyway, positive review for the typo fix.

comment:7 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 3.4.1.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.