Ticket #5493 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] improve Sphinx documentation of sr.py

Reported by: malb Owned by: malb
Priority: major Milestone: sage-3.4.1
Component: documentation Keywords: sphinx, crypto
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

The attached patch makes the Sphinx output for mq.SR look much nicer.

Attachments

sr_sphinx.patch Download (26.8 KB) - added by malb 4 years ago.
yay, my first sphinx patch

Change History

Changed 4 years ago by malb

yay, my first sphinx patch

comment:1 Changed 4 years ago by mabshoff

  • Summary changed from [with patch, needs review] to [with patch, needs review] improve Sphinx documentation of sr.py

comment:2 Changed 4 years ago by mvngu

  • Summary changed from [with patch, needs review] improve Sphinx documentation of sr.py to [with patch, positive review] improve Sphinx documentation of sr.py

REFEREE REPORT

The patch sr_sphinx.patch applied fine against Sage version 3.4. All tests passed, even with the -long option. The reference manual (which the patch touches) builds OK and looks rather prettier, which is what Martin wants :-) Positive review.

Note that while reviewing this ticket, I also noticed some further enhancements that can be done to sr.py. But these are addressed in ticket #5527.

comment:3 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.4.1.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.