Ticket #5481 (closed defect: fixed)

Opened 18 months ago

Last modified 14 months ago

[with patch, positive review] devel/doc/output/* should be filtered from the list of files to doctest

Reported by: mabshoff Owned by: mhansen
Priority: critical Milestone: sage-4.1
Component: doctest Keywords:
Cc: mhansen Author(s): John Palmieri
Report Upstream: Reviewer(s): Mike Hansen
Merged in: sage-4.1.alpha3 Work issues:

Description

There can be many rst files under devel/doc/output - those should be filtered from the list of files to doctest since they are duplicate doctests from the main Sage library in many cases.

Cheers,

Michael

Attachments

trac_5481_scripts.patch Download (1.2 KB) - added by jhpalmieri 15 months ago.

Change History

Changed 15 months ago by jhpalmieri

Has this been fixed? The file sage-maketest looks good to me already.

Changed 15 months ago by was

  • priority changed from blocker to critical

Changed 15 months ago by jhpalmieri

Maybe sage-ptest needs changing. I'm still trying to figure out what the issue is here.

Changed 15 months ago by jhpalmieri

Changed 15 months ago by jhpalmieri

  • summary changed from devel/doc/output/* should be filtered from the list of files to doctest to [with patch, needs review] devel/doc/output/* should be filtered from the list of files to doctest

Here's a patch. (The first change -- deleting all.py and init.py -- comes from #6108.)

Changed 15 months ago by mhansen

  • owner changed from mabshoff to mhansen
  • reviewer set to Mike Hansen
  • summary changed from [with patch, needs review] devel/doc/output/* should be filtered from the list of files to doctest to [with patch, positive review] devel/doc/output/* should be filtered from the list of files to doctest
  • status changed from new to assigned
  • author set to John Palmieri

Looks good to me.

Changed 14 months ago by boothby

  • status changed from assigned to closed
  • resolution set to fixed
  • merged set to sage-4.1.alpha2

Changed 14 months ago by rlm

  • merged changed from sage-4.1.alpha2 to sage-4.1.alpha3
Note: See TracTickets for help on using tickets.