Ticket #5467 (closed defect: fixed)

Opened 18 months ago

Last modified 6 weeks ago

The sage/macaulay2 interface doesn't work at all on large input

Reported by: was Owned by: mhansen
Priority: major Milestone: sage-4.5.2
Component: interfaces Keywords:
Cc: Author(s): Andrey Novoseltsev
Report Upstream: N/A Reviewer(s): Mike Hansen
Merged in: sage-4.5.2.alpha0 Work issues:

Description (last modified by novoselt) (diff)

ON OS X and Linux with Macaulay 1.2. 

teragon:~ wstein$ sage
----------------------------------------------------------------------
| Sage Version 3.4.alpha0, Release Date: 2009-02-24                  |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
sage: macaulay2(10^10000)
sage0
sage: macaulay2(10^10000)
sage1
sage: macaulay2(10^10000)
sage2

See also #7897 and #7915.

Attachments

5467_long_input_to_Macaulay2_second_part.patch Download (0.7 KB) - added by novoselt 8 months ago.
Must be applied after the first patch.
5467_long_input_to_Macaulay2.patch Download (1.7 KB) - added by novoselt 7 months ago.
Only this patch should be applied.

Change History

Changed 18 months ago by mabshoff

  • milestone changed from sage-3.4 to sage-3.4.1

Changed 8 months ago by novoselt

  • status changed from new to needs_review
  • upstream set to N/A
  • author set to Andrey Novoseltsev

This is a trivial fix - the problem was in a wrong file loading command passed to Macaulay2.

The tests in the modified function pass (although optional tests for the whole file give a bunch of unrelated mistakes).

Changed 8 months ago by novoselt

Must be applied after the first patch.

Changed 8 months ago by novoselt

I managed to make a trivial mistake in this trivial fix - one of the test lines was not marked with #optional. Now it is.

Changed 7 months ago by novoselt

Converged patches into a single one and made the commit message of standard form.

Changed 7 months ago by novoselt

Only this patch should be applied.

Changed 7 months ago by novoselt

  • description modified (diff)

Changed 8 weeks ago by mhansen

  • status changed from needs_review to positive_review
  • reviewer set to Mike Hansen

Looks good to me.

Changed 6 weeks ago by mpatel

  • status changed from positive_review to closed
  • resolution set to fixed
  • merged set to sage-4.5.2.alpha0
Note: See TracTickets for help on using tickets.