Ticket #5437 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch; positive review] pickle jar -- make it run through in order

Reported by: was Owned by: mabshoff
Priority: major Milestone: sage-3.4
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description (last modified by was) (diff)

Current when unpickling the pickle jar the files are run through in whatever order os.listdir gives them. This patch instead unpickles in order.

This is motivated by mabshoff's comment that the output of this doctest is "racy".

Attachments

trac_5437.patch Download (744 bytes) - added by was 4 years ago.

Change History

Changed 4 years ago by was

comment:1 Changed 4 years ago by was

  • Description modified (diff)

comment:2 Changed 4 years ago by mabshoff

  • Summary changed from [with patch; needs review] pickle jar -- make it run through in order to [with patch; positive review] pickle jar -- make it run through in order

Positive reiview.

Cheers,

Michael

comment:3 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.4.rc1.

Cheers,

Michael

Note: See TracTickets for help on using tickets.