Ticket #5436 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] more miscellaneous typos

Reported by: mvngu Owned by: tba
Priority: trivial Milestone: sage-3.4
Component: documentation Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

While reviewing ticket #5416, I came across a number of typos I saw in the rebased patch for that ticket. These problems were *not* introduced by the patch; they were not addressed.

Attachments

trac_5436_typos.patch Download (14.7 KB) - added by mvngu 4 years ago.
fixed typos in response to ticket #5416

Change History

Changed 4 years ago by mvngu

fixed typos in response to ticket #5416

comment:1 Changed 4 years ago by mvngu

  • Summary changed from more miscellaneous typos to [with patch, needs review] more miscellaneous typos

The patch fixes a number of typos I noticed while reviewing ticket #5416. It depends, of course, on applying #5416 first, and is based on Sage 3.4.rc0.

comment:2 Changed 4 years ago by mvngu

  • Milestone set to sage-3.4

comment:3 Changed 4 years ago by mabshoff

  • Summary changed from [with patch, needs review] more miscellaneous typos to [with patch, positive review] more miscellaneous typos

Looks good to me. This hunk 

-        Watch out, Magma has different semantics than Sage, i.e., in Magma
+        Watch out, Magma has different semantics from Sage, i.e., in Magma

seemed on first reading a little odd, but now I do agree with the change.

Cheers,

Michael

comment:4 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.4.rc1.

Cheers,

Michael

Note: See TracTickets for help on using tickets.