Ticket #5432 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] sage-combinat fixes: sage calls and qselect

Reported by: nthiery Owned by: nthiery
Priority: blocker Milestone: sage-3.4
Component: combinatorics Keywords:
Cc: sage-combinat Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Bug fixes:

  • Honor the SAGE_ROOT env variable to call sage
  • Removed config file handling which is now useless
  • Fixed missing default value for guards in qselect_backward_compatibility_patches

Attachments

sage-combinat-fixes.patch Download (2.3 KB) - added by nthiery 4 years ago.

Change History

Changed 4 years ago by nthiery

comment:1 Changed 4 years ago by nthiery

  • Summary changed from sage-combinat fixes: sage calls and qselect to sage-combinat fixes: sage calls and qselect [with patch, needs review]

comment:2 Changed 4 years ago by mabshoff

  • Cc mhansen added
  • Summary changed from sage-combinat fixes: sage calls and qselect [with patch, needs review] to [with patch, needs review] sage-combinat fixes: sage calls and qselect

Mike,

can you review this?

Cheers,

Michael

comment:3 Changed 4 years ago by mabshoff

  • Priority changed from major to blocker

Well, no point of shipping 3.4 with a broken combinat script, so make this a blocker :)

Cheers,

Michael

comment:4 Changed 4 years ago by hivert

  • Summary changed from [with patch, needs review] sage-combinat fixes: sage calls and qselect to [with patch, positive review] sage-combinat fixes: sage calls and qselect

Patch applies smootly and is working for me ! I'm giving it a +1.

comment:5 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.4.rc1.

Cheers,

Michael

comment:6 Changed 4 years ago by nthiery

  • Cc sage-combinat added; mhansen removed
Note: See TracTickets for help on using tickets.