Ticket #5387 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, needs review] a few changes to the installation guide

Reported by: jhpalmieri Owned by: jhpalmieri
Priority: minor Milestone: sage-3.4
Component: documentation Keywords: installation guide
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

At least one thing in the installation guide (a table) disappeared in the ReST conversion, and I've changed a few other things: how to build the documentation, a broken link, etc.

Attachments

installation.patch Download (5.4 KB) - added by jhpalmieri 4 years ago.
installation-part2.patch Download (5.8 KB) - added by jhpalmieri 4 years ago.
apply on top of other patch
trac_5387_reviewer-fixes.patch Download (3.6 KB) - added by mvngu 4 years ago.
reviewer fixes for above patches

Change History

Changed 4 years ago by jhpalmieri

comment:1 Changed 4 years ago by jhpalmieri

By the way, for the list of software, I just copied it from the old installation guide; I didn't check it for accuracy or omissions.

comment:2 Changed 4 years ago by wdj

Isn't the current list of software is on the wiki at  http://wiki.sagemath.org/standard_packages_available_for_SAGE? The list you have in the patch and that list from the wiki don't agree.

comment:3 Changed 4 years ago by jhpalmieri

I think the current list is actually in  http://sagemath.org/packages/standard/ or $SAGE_ROOT/spkg/installed, and the list there doesn't match the one in the installation guide or the one on the wiki.

Anyway, here's a patch (apply on top of the old one) with a new list.

Changed 4 years ago by jhpalmieri

apply on top of other patch

comment:4 Changed 4 years ago by wdj

  • Summary changed from [with patch, needs review] a few changes to the installation guide to [with patch, positive review] a few changes to the installation guide

Applies cleanly to sage-3.4.alpha0 using hg_sage.apply (*not* hg_doc). Compiles cleanly and without error.

Excellent job - thanks for making this patch!

comment:5 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged both patches in Sage 3.4.rc0.

Cheers,

Michael

Changed 4 years ago by mvngu

reviewer fixes for above patches

comment:6 Changed 4 years ago by mvngu

  • Keywords installation guide added
  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Summary changed from [with patch, positive review] a few changes to the installation guide to [with patch, needs review] a few changes to the installation guide

The patch trac_5387_reviewer-fixes.patch fixes some typos found in the patches by jhpalmieri.

comment:7 Changed 4 years ago by mabshoff

  • Status changed from reopened to closed
  • Resolution set to fixed

Do not reopen ticket that I have closed. Open a followup ticket - this is otherwise a giant mess.

Cheers,

Michael

comment:8 follow-up: ↓ 9 Changed 4 years ago by mabshoff

To keep things simple: Merged trac_5387_reviewer-fixes.patch in Sage 3.4.rc0.

Cheers,

Michael

comment:9 in reply to: ↑ 8 Changed 4 years ago by mvngu

Replying to mabshoff:

To keep things simple: Merged trac_5387_reviewer-fixes.patch in Sage 3.4.rc0.

Sorry about this, Michael. I'll keep your advice in mind.

Note: See TracTickets for help on using tickets.