Ticket #5368 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] plot3d is broken when variables not given

Reported by: was Owned by: was
Priority: major Milestone: sage-3.4
Component: graphics Keywords:
Cc: wcauchois Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description (last modified by was) (diff)

In released sage-3.3, this gives an infinite loop in the command line or notebook in OS X and Linux (sagenb.org): 

var('x,y')
plot3d(x*y^2 - sin(x), (-1,1), (-1,1))

Pretty bad!!

Attachments

trac_5368.patch Download (1.8 KB) - added by wcauchois 4 years ago.
trac_5368-rebased.patch Download (2.4 KB) - added by was 4 years ago.

Change History

comment:1 Changed 4 years ago by was

  • Description modified (diff)

comment:2 Changed 4 years ago by was

This is (probably) because fast_float isn't being used for some weird reason: 

sage: var('x,y')
(x, y)
sage: plot3d(x*y^2 - sin(x), (-1,1), (-1,1))
^CControl-C pressed.  Interrupting Maxima. Please wait a few seconds...
Exception exceptions.KeyboardInterrupt: KeyboardInterrupt() in  ignored
^C^CControl-C pressed.  Interrupting Maxima. Please wait a few seconds...
^CControl-C pressed.  Interrupting Maxima. Please wait a few seconds...
^CControl-C pressed.  Interrupting Maxima. Please wait a few seconds...

Changed 4 years ago by wcauchois

comment:3 Changed 4 years ago by wcauchois

  • Summary changed from plot3d is broken when variables not given to [with patch, needs review] plot3d is broken when variables not given

William's assessment was correct; the function was not being converted into a fast_float form because parametric_plot3d.adapt_to_callable was being invoked incorrectly. I tried to update the documentation of this function according to what I figured out about its workings, so that this mistake might be avoided in the future.

comment:4 Changed 4 years ago by wcauchois

  • Cc wcauchois@… added

comment:5 Changed 4 years ago by mabshoff

  • Cc wcauchois added; wcauchois@… removed
  • Milestone changed from sage-3.4 to sage-3.4.1

No need to add a complete email address, the account name in trac is sufficient.

Cheers,

Michael

comment:6 Changed 4 years ago by was

  • Summary changed from [with patch, needs review] plot3d is broken when variables not given to [with patch, positive review] plot3d is broken when variables not given

Changed 4 years ago by was

comment:7 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from sage-3.4.1 to sage-3.4

Merged trac_5368-rebased.patch in Sage 3.4.rc1.

Cheers,

Michael

Note: See TracTickets for help on using tickets.