Ticket #5357 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch; positive review] typos in library files; Sage 3.3

Reported by: mvngu Owned by: tba
Priority: minor Milestone: sage-3.4
Component: documentation Keywords:
Cc: mhansen Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

A bunch of typos found in Sage 3.3 library files, in particular files under the following directories:

  • sage/algebras
  • sage/calculus
  • sage/coding
  • sage/combinat
  • sage/crypto
  • sage/databases

The typos are fairly trivial to review.

Attachments

algebras.patch Download (873 bytes) - added by mvngu 4 years ago.
fixed typos in files under sage/algebras
calculus.patch Download (720 bytes) - added by mvngu 4 years ago.
fixed typos in files under sage/calculus
coding.patch Download (11.4 KB) - added by mvngu 4 years ago.
fixed typos in files under sage/coding
combinat-1.patch Download (26.4 KB) - added by mvngu 4 years ago.
fixed typos in files under sage/combinat; part 1
combinat-2.patch Download (25.7 KB) - added by mvngu 4 years ago.
fixed typos in files under sage/combinat; part 2
crypto.patch Download (4.3 KB) - added by mvngu 4 years ago.
fixed typos in files under sage/crypto
databases.patch Download (16.5 KB) - added by mvngu 4 years ago.
fixed typos in files under sage/databases
trac_5357.patch Download (65.2 KB) - added by mhansen 4 years ago.

Change History

Changed 4 years ago by mvngu

fixed typos in files under sage/algebras

Changed 4 years ago by mvngu

fixed typos in files under sage/calculus

Changed 4 years ago by mvngu

fixed typos in files under sage/coding

Changed 4 years ago by mvngu

fixed typos in files under sage/combinat; part 1

Changed 4 years ago by mvngu

fixed typos in files under sage/combinat; part 2

Changed 4 years ago by mvngu

fixed typos in files under sage/crypto

Changed 4 years ago by mvngu

fixed typos in files under sage/databases

comment:1 Changed 4 years ago by mvngu

  • Summary changed from typos in library file; Sage 3.3 to [with patches; needs review] typos in library files; Sage 3.3

comment:2 follow-up: ↓ 3 Changed 4 years ago by mabshoff

  • Cc mhansen added
  • Milestone changed from sage-3.4 to sage-3.4.1

Hi Minh,

the timing of these patches is rather unfortunate since they are against the old codebase without the ReST patches. Since that patches have preference about anything else two thing can happen:

  • Mike Hansen integrates the fixes into the ReST patch set
  • someone will need to rebase these patches for Sage 3.4.1.

Cheers,

Michael

comment:3 in reply to: ↑ 2 Changed 4 years ago by mvngu

Replying to mabshoff:

Hi Minh,

the timing of these patches is rather unfortunate since they are against the old codebase without the ReST patches. Since that patches have preference about anything else two thing can happen:

  • Mike Hansen integrates the fixes into the ReST patch set
  • someone will need to rebase these patches for Sage 3.4.1.

No problem. Leave the attached fixes as is and don't integrate them into 3.4. I don't want to further delay the ReSTification of the documentation and hence the release of 3.4 with that beautifully formatted standard documentation. I'll try to rebase the above patches for 3.4.1.

comment:4 Changed 4 years ago by mhansen

Actually, I can take care of it as I had already made a number of the SAGE -> Sage changes.

Changed 4 years ago by mhansen

comment:5 Changed 4 years ago by mhansen

  • Summary changed from [with patches; needs review] typos in library files; Sage 3.3 to [with patch; positive review] typos in library files; Sage 3.3

Looks good to me. I made a rebased trac_5357.patch.

comment:6 Changed 4 years ago by mhansen

(Just merge trac_5357.patch)

comment:7 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from sage-3.4.1 to sage-3.4

Merged in Sage 3.4.rc0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.