Ticket #5266 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] plot_vector_field does not plot the end of the range when given plot_points argument

Reported by: jason Owned by: jason
Priority: blocker Milestone: sage-3.3
Component: graphics Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

var('x,y')
plot_vector_field( (-1,y), (x, -1, 1), (y, -1, 1), plot_points=4)

picks the 4 points at x=-1, -0.5,0, and 0.5, but doesn't get x=1! The points it should pick are x=-1, -1/3, 1/3, and 1 (so we hit the end of the x-range). The same applies to y.

Attachments

trac_5266-plotting-fencepost-error.patch Download (2.4 KB) - added by jason 4 years ago.

Change History

comment:1 Changed 4 years ago by jason

  • Summary changed from plot_vector_field does not plot the end of the range when given plot_points argument to [with patch, needs review] plot_vector_field does not plot the end of the range when given plot_points argument

Changed 4 years ago by jason

comment:2 Changed 4 years ago by jason

  • Owner changed from was to jason
  • Status changed from new to assigned
  • Milestone changed from sage-3.4.1 to sage-3.3

comment:3 Changed 4 years ago by jason

  • Priority changed from major to blocker

mabshoff said to make this a blocker...

comment:4 Changed 4 years ago by mabshoff

All doctests pass with the patch applied, so now we need a formal review for this one.

Cheers,

Michael

comment:5 Changed 4 years ago by mhansen

  • Summary changed from [with patch, needs review] plot_vector_field does not plot the end of the range when given plot_points argument to [with patch, positive review] plot_vector_field does not plot the end of the range when given plot_points argument

Looks good to me.

comment:6 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 3.3.rc1.

Cheers,

Michael

Note: See TracTickets for help on using tickets.