id	summary	reporter	owner	description	type	status	priority	milestone	component	resolution	keywords	cc	work_issues	upstream	reviewer	author	merged	dependencies	stopgaps
5257	"[with patch, positive review] Clicking on ""Log"" in the notebook (bringing you to the /history page) gives errors"	jason	mhansen	"In the browser, I get:

{{{
Internal Server Error
An error occurred rendering the requested page. More information is available in the server log.
}}}

and I get a traceback as well:

{{{
2009-02-13 12:39:32-0600 [HTTPChannel,101,127.0.0.1] Exception rendering:
2009-02-13 12:39:32-0600 [HTTPChannel,101,127.0.0.1] Unhandled Error
	Traceback (most recent call last):
	  File ""/home/grout/sage/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-i686.egg/twisted/internet/defer.py"", line 186, in addCallbacks
	    self._runCallbacks()
	  File ""/home/grout/sage/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-i686.egg/twisted/internet/defer.py"", line 328, in _runCallbacks
	    self.result = callback(self.result, *args, **kw)
	  File ""/home/grout/sage/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-i686.egg/twisted/internet/defer.py"", line 289, in _continue
	    self.unpause()
	  File ""/home/grout/sage/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-i686.egg/twisted/internet/defer.py"", line 285, in unpause
	    self._runCallbacks()
	--- <exception caught here> ---
	  File ""/home/grout/sage/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-i686.egg/twisted/internet/defer.py"", line 328, in _runCallbacks
	    self.result = callback(self.result, *args, **kw)
	  File ""/home/grout/sage/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-i686.egg/twisted/web2/server.py"", line 296, in <lambda>
	    d.addCallback(lambda res, req: res.renderHTTP(req), self)
	  File ""/home/grout/sage/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-i686.egg/twisted/web2/resource.py"", line 85, in renderHTTP
	    return method(request)
	  File ""/home/grout/sage/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-i686.egg/twisted/web2/resource.py"", line 202, in http_GET
	    return super(Resource, self).http_GET(request)
	  File ""/home/grout/sage/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-i686.egg/twisted/web2/resource.py"", line 128, in http_GET
	    return self.render(request)
	  File ""/home/grout/sage/local/lib/python2.5/site-packages/sage/server/notebook/twist.py"", line 1633, in render
	    s = notebook.user_history_html(self.username)
	  File ""/home/grout/sage/local/lib/python2.5/site-packages/sage/server/notebook/notebook.py"", line 842, in user_history_html
	    """"""%(username, self.html_worksheet_list_top(username, actions=False), t)
	  File ""/home/grout/sage/local/lib/python2.5/site-packages/sage/server/notebook/notebook.py"", line 1318, in html_worksheet_list_top
	    s += self.html_new_or_upload()
	exceptions.AttributeError: 'Notebook' object has no attribute 'html_new_or_upload'
}}}
"	defect	closed	major	sage-3.3	notebook	fixed