Ticket #5147 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] make plot output file in DOCTEST_MODE changeable for sage-mode.el

Reported by: ncalexan Owned by: mabshoff
Priority: major Milestone: sage-3.3
Component: doctest coverage Keywords: doctest plot output filename
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Whilst incorporating sage-view.el into sage-mode.el, I needed to be able to change the output filename while in DOCTEST_MODE. This tiny patches adds a module scope variable name with the output file name.

Attachments

trac_5147-plot-output-filename.patch Download (1.4 KB) - added by ncalexan 4 years ago.

Change History

Changed 4 years ago by ncalexan

comment:1 Changed 4 years ago by ncalexan

  • Summary changed from make plot output file in DOCTEST_MODE changeable for sage-mode.el to [with patch, needs review] make plot output file in DOCTEST_MODE changeable for sage-mode.el

I see this as harmless, and it is very useful to me and users of sage-mode.el...

comment:2 Changed 4 years ago by mhansen

  • Summary changed from [with patch, needs review] make plot output file in DOCTEST_MODE changeable for sage-mode.el to [with patch, positive review] make plot output file in DOCTEST_MODE changeable for sage-mode.el

Looks good to me.

comment:3 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.3.alpha4.

Cheers,

Michael

Note: See TracTickets for help on using tickets.